mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-02-02 07:01:30 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(core): fix workflow hasing for MySQL (#4491)

Browse source 
* 🐛 Alphabetize node keys

* 🔥 Remove excess braces
This commit is contained in:
Iván Ovejero 2022-11-01 13:51:13 +01:00 committed by GitHub
parent e1a3f56651
commit 2b5613ed68
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/cli/src/databases/entities/WorkflowEntity.ts
View file

@ -29,6 +29,7 @@ import { SharedWorkflow } from './SharedWorkflow';
import { objectRetriever, sqlite } from '../utils/transformers'; import { objectRetriever, sqlite } from '../utils/transformers';
import { AbstractEntity, jsonColumnType } from './AbstractEntity'; import { AbstractEntity, jsonColumnType } from './AbstractEntity';
import type { IWorkflowDb } from '../../Interfaces'; import type { IWorkflowDb } from '../../Interfaces';
import { alphabetizeKeys } from '../../utils';
@Entity() @Entity()
export class WorkflowEntity extends AbstractEntity implements IWorkflowDb { export class WorkflowEntity extends AbstractEntity implements IWorkflowDb {
@ -103,7 +104,7 @@ export class WorkflowEntity extends AbstractEntity implements IWorkflowDb {
const state = JSON.stringify({ const state = JSON.stringify({
name, name,
active, active,
nodes, nodes: nodes ? nodes.map(alphabetizeKeys) : [],
connections, connections,
settings, settings,
staticData, staticData,

13
packages/cli/src/utils.ts
View file

@ -1,3 +1,4 @@
/* eslint-disable @typescript-eslint/no-unsafe-assignment */
import { CliWorkflowOperationError, SubworkflowOperationError } from 'n8n-workflow'; import { CliWorkflowOperationError, SubworkflowOperationError } from 'n8n-workflow';
import type { INode } from 'n8n-workflow'; import type { INode } from 'n8n-workflow';
@ -28,3 +29,15 @@ function findWorkflowStart(executionMode: 'integrated' | 'cli') {
export const findSubworkflowStart = findWorkflowStart('integrated'); export const findSubworkflowStart = findWorkflowStart('integrated');
export const findCliWorkflowStart = findWorkflowStart('cli'); export const findCliWorkflowStart = findWorkflowStart('cli');
export const alphabetizeKeys = (obj: INode) =>
Object.keys(obj)
.sort()
.reduce<Partial<INode>>(
(acc, key) => ({
...acc,
// @ts-expect-error @TECH_DEBT Adding index signature to INode causes type issues downstream
[key]: obj[key],
}),
{},
);