mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-09 22:24:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor(core): Remove ID-less workflow reporting (no-changelog) (#8038)

Browse source 
We added ID-less workflow reporting at #8031, which has already produced
multiple reports coming from internal, enough info to tackle [this
story](https://linear.app/n8n/issue/PAY-1147). To prevent an
overwhelming number of reports from cloud, this PR removes the reporting
for now.
This commit is contained in:
Iván Ovejero 2023-12-15 12:50:09 +01:00 committed by GitHub
parent 3d530522f8
commit 2da15d0264
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
packages/cli/src/commands/worker.ts
View file

@ -13,13 +13,7 @@ import type {
INodeTypes, INodeTypes,
IRun, IRun,
} from 'n8n-workflow'; } from 'n8n-workflow';
import { import { Workflow, NodeOperationError, sleep, ApplicationError } from 'n8n-workflow';
Workflow,
NodeOperationError,
sleep,
ApplicationError,
ErrorReporterProxy as EventReporter,
} from 'n8n-workflow';
import * as Db from '@/Db'; import * as Db from '@/Db';
import * as ResponseHelper from '@/ResponseHelper'; import * as ResponseHelper from '@/ResponseHelper';
@ -138,13 +132,6 @@ export class Worker extends BaseCommand {
} }
const workflowId = fullExecutionData.workflowData.id!; // @tech_debt Ensure this is not optional const workflowId = fullExecutionData.workflowData.id!; // @tech_debt Ensure this is not optional
if (!workflowId) {
EventReporter.report('Detected ID-less workflow', {
level: 'info',
extra: { execution: fullExecutionData },
});
}
this.logger.info( this.logger.info(
`Start job: ${job.id} (Workflow ID: ${workflowId} | Execution: ${executionId})`, `Start job: ${job.id} (Workflow ID: ${workflowId} | Execution: ${executionId})`,
); );

8
packages/workflow/src/Workflow.ts
View file

@ -52,7 +52,6 @@ import { RoutingNode } from './RoutingNode';
import { Expression } from './Expression'; import { Expression } from './Expression';
import { NODES_WITH_RENAMABLE_CONTENT } from './Constants'; import { NODES_WITH_RENAMABLE_CONTENT } from './Constants';
import { ApplicationError } from './errors/application.error'; import { ApplicationError } from './errors/application.error';
import * as EventReporter from './ErrorReporterProxy';
function dedupe<T>(arr: T[]): T[] { function dedupe<T>(arr: T[]): T[] {
return [...new Set(arr)]; return [...new Set(arr)];
@ -95,13 +94,6 @@ export class Workflow {
settings?: IWorkflowSettings; settings?: IWorkflowSettings;
pinData?: IPinData; pinData?: IPinData;
}) { }) {
if (!parameters.id) {
EventReporter.report('Detected ID-less workflow', {
level: 'info',
extra: { parameters },
});
}
this.id = parameters.id as string; // @tech_debt Ensure this is not optional this.id = parameters.id as string; // @tech_debt Ensure this is not optional
this.name = parameters.name; this.name = parameters.name;
this.nodeTypes = parameters.nodeTypes; this.nodeTypes = parameters.nodeTypes;