Simplify documentation help code and display only if URL is set

This commit is contained in:
Jan Oberhauser 2020-09-23 11:10:23 +02:00
parent 88ccc5cb6f
commit 2db6ae0f76

View file

@ -4,7 +4,7 @@
<div name="title" class="title-container" slot="title"> <div name="title" class="title-container" slot="title">
<div class="title-left">{{title}}</div> <div class="title-left">{{title}}</div>
<div class="title-right"> <div class="title-right">
<div v-if="credentialType" class="docs-container"> <div v-if="credentialType && documentationUrl" class="docs-container">
<svg class="help-logo" target="_blank" width="18px" height="18px" viewBox="0 0 18 18" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> <svg class="help-logo" target="_blank" width="18px" height="18px" viewBox="0 0 18 18" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
<title>Node Documentation</title> <title>Node Documentation</title>
<g stroke="none" stroke-width="1" fill="none" fill-rule="evenodd"> <g stroke="none" stroke-width="1" fill="none" fill-rule="evenodd">
@ -20,7 +20,7 @@
</g> </g>
</g> </g>
</svg> </svg>
<span v-if="credentialType" class="doc-link-text">Need help? <a class="doc-hyperlink" :href="'https://docs.n8n.io/credentials/' + documentationUrl + '/?utm_source=n8n_app&utm_medium=left_nav_menu&utm_campaign=create_new_credentials_modal'" target="_blank">Open credential docs</a></span> <span class="doc-link-text">Need help? <a class="doc-hyperlink" :href="'https://docs.n8n.io/credentials/' + documentationUrl + '/?utm_source=n8n_app&utm_medium=left_nav_menu&utm_campaign=create_new_credentials_modal'" target="_blank">Open credential docs</a></span>
</div> </div>
</div> </div>
</div> </div>
@ -109,26 +109,17 @@ export default mixins(
} }
} }
}, },
documentationUrl (): string { documentationUrl (): string | undefined {
let credentialTypeName = '';
if (this.editCredentials) { if (this.editCredentials) {
const credentialType = this.$store.getters.credentialType(this.editCredentials.type); credentialTypeName = this.editCredentials.type;
if (credentialType.documentationUrl === undefined) {
return credentialType.name;
} else {
return `${credentialType.documentationUrl}`;
}
} else { } else {
if (this.credentialType) { credentialTypeName = this.credentialType;
const credentialType = this.$store.getters.credentialType(this.credentialType); }
if (credentialType.documentationUrl === undefined) { const credentialType = this.$store.getters.credentialType(credentialTypeName);
return credentialType.name; if (credentialType.documentationUrl !== undefined) {
} else { return `${credentialType.documentationUrl}`;
return `${credentialType.documentationUrl}`;
}
} else {
return '';
}
} }
}, },
node (): INodeUi { node (): INodeUi {