From 2df0c2c4732095331586a3b3ae72d59e1742fa13 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Tue, 1 Aug 2023 13:47:55 +0200 Subject: [PATCH] refactor: Clear unused ESLint directives from FE packages (no-changelog) (#6811) --- packages/design-system/package.json | 4 +- .../src/components/N8nHeading/Heading.vue | 2 - .../RecycleScroller.stories.ts | 1 - .../N8nResizeWrapper/ResizeWrapper.vue | 1 - .../src/components/N8nText/Text.vue | 2 - .../components/N8nUserSelect/UserSelect.vue | 1 - .../ResizeObserver/ResizeObserver.vue | 2 +- .../design-system/src/utils/valueByPath.ts | 2 +- packages/editor-ui/package.json | 4 +- packages/editor-ui/src/App.vue | 2 +- packages/editor-ui/src/Interface.ts | 2 +- .../editor-ui/src/__tests__/server/types.ts | 1 - .../src/components/BreakpointsObserver.vue | 2 +- .../CredentialEdit/CredentialEdit.vue | 2 +- .../src/components/ExecutionFilter.vue | 2 +- .../ExecutionsView/ExecutionsList.vue | 4 +- .../src/components/ExpressionEdit.vue | 2 - .../ExpressionEditorModalOutput.vue | 3 +- .../InlineExpressionEditorOutput.vue | 3 +- .../Node/NodeCreator/ItemTypes/NodeItem.vue | 1 - .../editor-ui/src/components/NodeSettings.vue | 1 - .../src/components/ParameterInput.vue | 3 - .../editor-ui/src/components/RunDataTable.vue | 1 - .../src/components/WorkflowSettings.vue | 164 ++++++++---------- packages/editor-ui/src/main.ts | 6 +- packages/editor-ui/src/mixins/debounce.ts | 1 - .../editor-ui/src/mixins/genericHelpers.ts | 1 - .../editor-ui/src/mixins/pushConnection.ts | 2 +- .../editor-ui/src/stores/workflows.store.ts | 1 - packages/editor-ui/src/utils/sortUtils.ts | 2 +- packages/editor-ui/src/views/NodeView.vue | 29 ++-- 31 files changed, 108 insertions(+), 146 deletions(-) diff --git a/packages/design-system/package.json b/packages/design-system/package.json index 44d0c8908f..30643d63f0 100644 --- a/packages/design-system/package.json +++ b/packages/design-system/package.json @@ -22,8 +22,8 @@ "build:storybook": "storybook build", "storybook": "storybook dev -p 6006", "format": "prettier --write . --ignore-path ../../.prettierignore", - "lint": "eslint --quiet --ext .js,.ts,.vue src", - "lintfix": "eslint --ext .js,.ts,.vue src --fix" + "lint": "eslint src --ext .js,.ts,.vue --quiet --report-unused-disable-directives", + "lintfix": "eslint src --ext .js,.ts,.vue --fix --report-unused-disable-directives" }, "peerDependencies": { "@fortawesome/fontawesome-svg-core": "1.x", diff --git a/packages/design-system/src/components/N8nHeading/Heading.vue b/packages/design-system/src/components/N8nHeading/Heading.vue index 81da7e7bca..24ad2c2a09 100644 --- a/packages/design-system/src/components/N8nHeading/Heading.vue +++ b/packages/design-system/src/components/N8nHeading/Heading.vue @@ -40,14 +40,12 @@ export default defineComponent({ classes() { const applied = []; if (this.align) { - // eslint-disable-next-line @typescript-eslint/restrict-template-expressions applied.push(`align-${this.align}`); } if (this.color) { applied.push(this.color); } - // eslint-disable-next-line @typescript-eslint/restrict-template-expressions applied.push(`size-${this.size}`); applied.push(this.bold ? 'bold' : 'regular'); diff --git a/packages/design-system/src/components/N8nRecycleScroller/RecycleScroller.stories.ts b/packages/design-system/src/components/N8nRecycleScroller/RecycleScroller.stories.ts index d9e5a75ba9..b279708d9d 100644 --- a/packages/design-system/src/components/N8nRecycleScroller/RecycleScroller.stories.ts +++ b/packages/design-system/src/components/N8nRecycleScroller/RecycleScroller.stories.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-assignment */ import type { StoryFn } from '@storybook/vue3'; import N8nRecycleScroller from './RecycleScroller.vue'; import type { ComponentInstance } from 'vue'; diff --git a/packages/design-system/src/components/N8nResizeWrapper/ResizeWrapper.vue b/packages/design-system/src/components/N8nResizeWrapper/ResizeWrapper.vue index 930e4eb608..d9259431da 100644 --- a/packages/design-system/src/components/N8nResizeWrapper/ResizeWrapper.vue +++ b/packages/design-system/src/components/N8nResizeWrapper/ResizeWrapper.vue @@ -12,7 +12,6 @@