mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

⚡Improve auth error detection

Browse source
This commit is contained in:
Milorad Filipovic 2025-03-05 11:22:25 +01:00
parent 010f819bb0
commit 2e41075fc8
No known key found for this signature in database
2 changed files with 60 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
packages/frontend/editor-ui/src/components/ResourceLocator/ResourceLocator.vue
View file

@ -63,6 +63,7 @@ interface IResourceLocatorQuery {
message?: string;
description?: string;
httpCode?: string;
stackTrace?: string;
};
loading: boolean;
}
@ -154,9 +155,26 @@ const selectedMode = computed(() => {
const isListMode = computed(() => selectedMode.value === 'list');
const hasPermissionError = computed(() =>
['401', '403'].includes(currentResponse.value?.errorDetails?.httpCode ?? ''),
);
const hasCredentialError = computed(() => {
const PERMISSION_ERROR_CODES = ['401', '403'];
// Some of our NodeAPIErrors just return 500 without any details,
// so checking messages and stack traces for permission errors
const NODE_API_AUTH_ERROR_MESSAGES = [
'NodeApiError: Authorization failed',
'NodeApiError: Unable to sign without access token',
'secretOrPrivateKey must be an asymmetric key when using RS256',
];
// Check if error stack trace contains permission error messages
const stackTraceContainsCredentialError = (currentResponse.value?.errorDetails?.stackTrace ?? '')
.split('\n')
.some((line) => NODE_API_AUTH_ERROR_MESSAGES.includes(line.trim()));
return (
PERMISSION_ERROR_CODES.includes(currentResponse.value?.errorDetails?.httpCode ?? '') ||
NODE_API_AUTH_ERROR_MESSAGES.includes(currentResponse.value?.errorDetails?.message ?? '') ||
stackTraceContainsCredentialError
);
});
const credentialsNotSet = computed(() => {
if (!props.node) return false;
@ -784,28 +802,31 @@ function removeOverride() {
@load-more="loadResourcesDebounced"
>
<template #error>
<div
v-if="currentResponse.errorDetails"
:class="$style.error"
data-test-id="rlc-error-container"
<div :class="$style.errorContainer" data-test-id="rlc-error-container">
<n8n-text
v-if="credentialsNotSet || currentResponse.errorDetails"
color="text-dark"
align="center"
tag="div"
>
<n8n-text color="text-dark" align="center" tag="div" class="mb-3xs">
{{ i18n.baseText('resourceLocator.mode.list.error.title') }}
</n8n-text>
<div v-if="currentResponse.errorDetails" :class="$style.errorDetails">
<n8n-text size="small">
<span v-if="currentResponse.errorDetails.httpCode">
{{ currentResponse.errorDetails.httpCode }} -
</span>
{{ currentResponse.errorDetails.message?.split('-')[0]?.trim() }}
{{ currentResponse.errorDetails.message }}
</n8n-text>
<N8nNotice
v-if="currentResponse.errorDetails.description"
theme="warning"
class="mt-s mb-s text-left"
:class="$style.errorDescription"
>
{{ currentResponse.errorDetails.description }}
</N8nNotice>
<div v-if="hasPermissionError" data-test-id="permission-error-link">
</div>
<div v-if="hasCredentialError || credentialsNotSet" data-test-id="permission-error-link">
<a
v-if="credentialsNotSet"
:class="$style['credential-link']"

20
packages/frontend/editor-ui/src/components/ResourceLocator/resourceLocator.scss
View file

@ -140,15 +140,27 @@ $--mode-selector-width: 92px;
cursor: pointer;
}
.error {
.errorContainer,
.errorDetails {
display: flex;
gap: var(--spacing-s);
flex-direction: column;
}
.errorContainer {
width: 80%;
word-break: normal;
align-items: center;
text-align: center;
color: var(--color-text-base);
}
.errorDescription {
text-align: left;
margin: 0;
word-break: normal;
}
.credential-link {
font-size: 12px;
font-size: var(--font-size-2xs);
}
.openResourceLink {