mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-10 06:34:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

delete left over deleteNote code and change defdault currencies

Browse source
This commit is contained in:
quansenB 2019-10-29 23:45:20 +01:00
parent 51a6b47985
commit 2e56730fad
2 changed files with 15 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
packages/nodes-base/nodes/ActiveCampaign/ActiveCampaign.node.ts
View file

@ -577,7 +577,7 @@ export class ActiveCampaign implements INodeType {
},
{
displayName: 'Deal pipeline ID',
name: 'pipeline',
name: 'owner',
type: 'string',
default: '',
displayOptions: {
@ -650,7 +650,7 @@ export class ActiveCampaign implements INodeType {
default: '',
description: 'The description of the deal',
},
{
displayName: 'Deal percentage',
name: 'percent',
@ -745,7 +745,7 @@ export class ActiveCampaign implements INodeType {
},
{
displayName: 'Deal pipeline ID',
name: 'pipeline',
name: 'owner',
type: 'string',
default: '',
description: 'The pipeline ID of the deal',
@ -966,6 +966,7 @@ export class ActiveCampaign implements INodeType {
},
description: 'The content of the deal note',
},
],
};
@ -1090,18 +1091,18 @@ export class ActiveCampaign implements INodeType {
value: this.getNodeParameter('value', i) as number,
} as IDataObject;
const group = this.getNodeParameter('pipeline', i) as string
if(group !== ''){
const group = this.getNodeParameter('owner', i) as string
if (group !== '') {
addAdditionalFields(body.deal as IDataObject, { group })
}
const owner = this.getNodeParameter('owner', i) as string
if(owner !== ''){
if (owner !== '') {
addAdditionalFields(body.deal as IDataObject, { owner })
}
const stage = this.getNodeParameter('stage', i) as string
if(stage !== ''){
if (stage !== '') {
addAdditionalFields(body.deal as IDataObject, { stage })
}
@ -1188,9 +1189,11 @@ export class ActiveCampaign implements INodeType {
const dealNoteId = this.getNodeParameter('dealNoteId', i) as number;
endpoint = `/api/3/deals/${dealId}/notes/${dealNoteId}`;
} else {
throw new Error(`The operation "${operation}" is not known`);
}
} else {
throw new Error(`The resource "${resource}" is not known!`);
}
@ -1212,3 +1215,4 @@ export class ActiveCampaign implements INodeType {
return [this.helpers.returnJsonArray(returnData)];
}
}

8
packages/nodes-base/nodes/ActiveCampaign/currencies.ts
View file

@ -1,7 +1,9 @@
export function returnAllCurrencyOptions() {
return [
{ name: 'United States Dollar', value: 'usd' },
return [
{ name: 'Euro', value: 'eur' },
{ name: 'United States Dollar', value: 'usd' },
{ name: 'British Pound Sterling', value: 'gbp' },
{ name: 'Swiss Franc', value: 'chf' },
{ name: 'Renminbi', value: 'cny' },
{ name: '--------', value: '' },
{ name: 'United Arab Emirates Dirham', value: 'aed' },
@ -32,7 +34,6 @@ export function returnAllCurrencyOptions() {
{ name: 'Belize Dollar', value: 'bzd' },
{ name: 'Canadian Dollar', value: 'cad' },
{ name: 'Congolese Franc', value: 'cdf' },
{ name: 'Swiss Franc', value: 'chf' },
{ name: 'Chilean Unit of Account (UF)', value: 'clf' },
{ name: 'Chilean Peso', value: 'clp' },
{ name: 'Chinese Yuan (Offshore)', value: 'cnh' },
@ -51,7 +52,6 @@ export function returnAllCurrencyOptions() {
{ name: 'Ethiopian Birr', value: 'etb' },
{ name: 'Fijian Dollar', value: 'fjd' },
{ name: 'Falkland Islands Pound', value: 'fkp' },
{ name: 'British Pound Sterling', value: 'gbp' },
{ name: 'Georgian Lari', value: 'gel' },
{ name: 'Guernsey Pound', value: 'ggp' },
{ name: 'Ghanaian Cedi', value: 'ghs' },