From 30aeeb70b43ff3916ad79abbe49512a27e50d01d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E0=A4=95=E0=A4=BE=E0=A4=B0=E0=A4=A4=E0=A5=8B=E0=A4=AB?= =?UTF-8?q?=E0=A5=8D=E0=A4=AB=E0=A5=87=E0=A4=B2=E0=A4=B8=E0=A5=8D=E0=A4=95?= =?UTF-8?q?=E0=A5=8D=E0=A4=B0=E0=A4=BF=E0=A4=AA=E0=A5=8D=E0=A4=9F=E2=84=A2?= Date: Fri, 24 Mar 2023 17:29:56 +0100 Subject: [PATCH] fix(core): Ensure that all non-lazy-loaded community nodes get post-processed correctly (#5782) If you install a community node with `polling: true`, activating a workflow with that node fails with an error: `WorkflowActivationError: There was a problem activating the workflow: "Could not get parameter "pollTimes"!"`. You can test this by installing `n8n-nodes-rss-feed-trigger`, creating a workflow with the `RSS Trigger` node, and then trying to activate it. Activation will fail on `master`, but work as expected on this branch. --- packages/cli/src/commands/start.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/cli/src/commands/start.ts b/packages/cli/src/commands/start.ts index 991d19e9d4..db53900de2 100644 --- a/packages/cli/src/commands/start.ts +++ b/packages/cli/src/commands/start.ts @@ -60,7 +60,7 @@ export class Start extends BaseCommand { }), }; - protected activeWorkflowRunner = Container.get(ActiveWorkflowRunner); + protected activeWorkflowRunner: ActiveWorkflowRunner; /** * Opens the UI in browser @@ -200,6 +200,7 @@ export class Start extends BaseCommand { await this.initCrashJournal(); await super.init(); this.logger.info('Initializing n8n process'); + this.activeWorkflowRunner = Container.get(ActiveWorkflowRunner); await this.initLicense(); await this.initBinaryManager();