mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 12:44:07 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: Cast boolean values in filter parameter (#9260)

Browse source
This commit is contained in:
Elias Meire 2024-05-02 17:01:00 +02:00 committed by GitHub
parent d3e0640674
commit 30c8efc4cc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 32 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
packages/workflow/src/NodeParameters/FilterParameter.ts
View file

@ -32,9 +32,15 @@ function parseSingleFilterValue(
type: FilterOperatorType, type: FilterOperatorType,
strict = false, strict = false,
): ValidationResult { ): ValidationResult {
return type === 'any' || value === null || value === undefined if (type === 'any' || value === null || value === undefined) {
? ({ valid: true, newValue: value } as ValidationResult) return { valid: true, newValue: value } as ValidationResult;
: validateFieldType('filter', value, type, { strict, parseStrings: true }); }
if (type === 'boolean' && !strict) {
return { valid: true, newValue: Boolean(value) };
}
return validateFieldType('filter', value, type, { strict, parseStrings: true });
} }
const withIndefiniteArticle = (noun: string): string => { const withIndefiniteArticle = (noun: string): string => {

25
packages/workflow/test/FilterParameter.test.ts
View file

@ -177,6 +177,27 @@ describe('FilterParameter', () => {
leftValue: 'true', leftValue: 'true',
operator: { operation: 'true', type: 'boolean' }, operator: { operation: 'true', type: 'boolean' },
}, },
{
id: '3',
leftValue: '',
operator: { operation: 'false', type: 'boolean' },
},
{
id: '4',
leftValue: 0,
operator: { operation: 'false', type: 'boolean' },
},
{
id: '5',
leftValue: 1,
operator: { operation: 'true', type: 'boolean' },
},
{
id: '6',
leftValue: 'a string',
operator: { operation: 'true', type: 'boolean' },
},
], ],
options: { typeValidation: 'loose' }, options: { typeValidation: 'loose' },
}), }),
@ -194,14 +215,14 @@ describe('FilterParameter', () => {
id: '1', id: '1',
leftValue: 'a string', leftValue: 'a string',
rightValue: 15, rightValue: 15,
operator: { operation: 'equals', type: 'boolean' }, operator: { operation: 'equals', type: 'number' },
}, },
], ],
options: { typeValidation: 'loose' }, options: { typeValidation: 'loose' },
}), }),
), ),
).toThrowError( ).toThrowError(
"Conversion error: the string 'a string' can't be converted to a boolean [condition 0, item 0]", "Conversion error: the string 'a string' can't be converted to a number [condition 0, item 0]",
); );
}); });
}); });