mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 12:44:07 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(HTTP Request Node): Require parameter with filled name and value to avoid infinite loop (#8454)

Browse source 
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
Co-authored-by: Elias Meire <elias@meire.dev>
This commit is contained in:
Michael Kret 2024-02-01 10:35:39 +00:00 committed by GitHub
parent ca75744c7f
commit 3128dca1fa
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 27 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts
View file

@ -1044,12 +1044,14 @@ export class HttpRequestV3 implements INodeType {
name: 'name', name: 'name',
type: 'string', type: 'string',
default: '', default: '',
placeholder: 'e.g page',
}, },
{ {
displayName: 'Value', displayName: 'Value',
name: 'value', name: 'value',
type: 'string', type: 'string',
default: '', default: '',
hint: 'Use expression mode and $response to access response data',
}, },
], ],
}, },
@ -1661,11 +1663,34 @@ export class HttpRequestV3 implements INodeType {
if (pagination.paginationMode === 'updateAParameterInEachRequest') { if (pagination.paginationMode === 'updateAParameterInEachRequest') {
// Iterate over all parameters and add them to the request // Iterate over all parameters and add them to the request
paginationData.request = {}; paginationData.request = {};
pagination.parameters.parameters.forEach((parameter) => { const { parameters } = pagination.parameters;
if (parameters.length === 1 && parameters[0].name === '' && parameters[0].value === '') {
throw new NodeOperationError(
this.getNode(),
"At least one entry with 'Name' and 'Value' filled must be included in 'Parameters' to use 'Update a Parameter in Each Request' mode ",
);
}
pagination.parameters.parameters.forEach((parameter, index) => {
if (!paginationData.request[parameter.type]) { if (!paginationData.request[parameter.type]) {
paginationData.request[parameter.type] = {}; paginationData.request[parameter.type] = {};
} }
paginationData.request[parameter.type]![parameter.name] = parameter.value; const parameterName = parameter.name;
if (parameterName === '') {
throw new NodeOperationError(
this.getNode(),
`Parameter name must be set for parameter [${index + 1}] in pagination settings`,
);
}
const parameterValue = parameter.value;
if (parameterValue === '') {
throw new NodeOperationError(
this.getNode(),
`Some value must be provided for parameter [${
index + 1
}] in pagination settings, omitting it will result in an infinite loop`,
);
}
paginationData.request[parameter.type]![parameterName] = parameterValue;
}); });
} else if (pagination.paginationMode === 'responseContainsNextURL') { } else if (pagination.paginationMode === 'responseContainsNextURL') {
paginationData.request.url = pagination.nextURL; paginationData.request.url = pagination.nextURL;