mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-14 08:34:07 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix(editor): Fix success state for disabled nodes in new canvas (no-changelog) (#11039)
Some checks are pending
Test Master / install-and-build (push) Waiting to run
Details
Test Master / Unit tests (18.x) (push) Blocked by required conditions
Details
Test Master / Unit tests (20.x) (push) Blocked by required conditions
Details
Test Master / Unit tests (22.4) (push) Blocked by required conditions
Details
Test Master / Lint (push) Blocked by required conditions
Details
Test Master / Notify Slack on failure (push) Blocked by required conditions
Details

Browse source
This commit is contained in:
Alex Grozav 2024-10-01 21:06:33 +03:00 committed by GitHub
parent e04b980dff
commit 3191912168
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/editor-ui/src/components/canvas/elements/nodes/render-types/CanvasNodeDefault.vue
View file

@ -118,7 +118,7 @@ function openContextMenu(event: MouseEvent) {
<FontAwesomeIcon icon="bolt" size="lg" /> <FontAwesomeIcon icon="bolt" size="lg" />
</div> </div>
</N8nTooltip> </N8nTooltip>
<CanvasNodeStatusIcons :class="$style.statusIcons" /> <CanvasNodeStatusIcons v-if="!isDisabled" :class="$style.statusIcons" />
<CanvasNodeDisabledStrikeThrough v-if="isStrikethroughVisible" /> <CanvasNodeDisabledStrikeThrough v-if="isStrikethroughVisible" />
<div :class="$style.description"> <div :class="$style.description">
<div v-if="label" :class="$style.label"> <div v-if="label" :class="$style.label">

9
packages/editor-ui/src/components/canvas/elements/nodes/render-types/parts/CanvasNodeDisabledStrikeThrough.vue
View file

@ -1,18 +1,15 @@
<script setup lang="ts"> <script setup lang="ts">
import { computed, useCssModule } from 'vue'; import { computed, useCssModule } from 'vue';
import { useCanvasNode } from '@/composables/useCanvasNode';
const $style = useCssModule(); const $style = useCssModule();
const isSuccessStatus = computed( const { hasRunData } = useCanvasNode();
() => false,
// @TODO Implement this
// () => !['unknown'].includes(node.status) && workflowDataItems > 0,
);
const classes = computed(() => { const classes = computed(() => {
return { return {
[$style.disabledStrikeThrough]: true, [$style.disabledStrikeThrough]: true,
[$style.success]: isSuccessStatus.value, [$style.success]: hasRunData.value,
}; };
}); });
</script> </script>