mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(node): Freshdesk - fix issue when getAll operation requires non existent options

Browse source
This commit is contained in:
Michael Kret 2022-08-19 16:42:15 +03:00 committed by GitHub
parent 43e054f5ab
commit 329fe9581f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/nodes-base/nodes/Freshdesk/Freshdesk.node.ts
View file

@ -683,7 +683,6 @@ export class Freshdesk implements INodeType {
displayName: 'Priority', displayName: 'Priority',
name: 'priority', name: 'priority',
type: 'options', type: 'options',
required: true,
options: [ options: [
{ {
name: 'Low', name: 'Low',
@ -759,7 +758,6 @@ export class Freshdesk implements INodeType {
displayName: 'Status', displayName: 'Status',
name: 'status', name: 'status',
type: 'options', type: 'options',
required: true,
options: [ options: [
{ {
name: 'Open', name: 'Open',

8
packages/nodes-base/nodes/Freshdesk/GenericFunctions.ts
View file

@ -2,7 +2,7 @@ import { OptionsWithUri } from 'request';
import { BINARY_ENCODING, IExecuteFunctions, ILoadOptionsFunctions } from 'n8n-core'; import { BINARY_ENCODING, IExecuteFunctions, ILoadOptionsFunctions } from 'n8n-core';
import { IDataObject, NodeApiError, NodeOperationError } from 'n8n-workflow'; import { IDataObject, NodeApiError } from 'n8n-workflow';
export async function freshdeskApiRequest( export async function freshdeskApiRequest(
this: IExecuteFunctions | ILoadOptionsFunctions, this: IExecuteFunctions | ILoadOptionsFunctions,
@ -13,8 +13,7 @@ export async function freshdeskApiRequest(
query: IDataObject = {}, query: IDataObject = {},
uri?: string, uri?: string,
option: IDataObject = {}, option: IDataObject = {},
// tslint:disable-next-line:no-any ) {
): Promise<any> {
const credentials = await this.getCredentials('freshdeskApi'); const credentials = await this.getCredentials('freshdeskApi');
const apiKey = `${credentials.apiKey}:X`; const apiKey = `${credentials.apiKey}:X`;
@ -53,8 +52,7 @@ export async function freshdeskApiRequestAllItems(
// tslint:disable-next-line:no-any // tslint:disable-next-line:no-any
body: any = {}, body: any = {},
query: IDataObject = {}, query: IDataObject = {},
// tslint:disable-next-line:no-any ) {
): Promise<any> {
const returnData: IDataObject[] = []; const returnData: IDataObject[] = [];
let responseData; let responseData;