mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-24 20:24:05 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(core): Declutter webhook insertion errors (#10650)
Some checks are pending
Test Master / install-and-build (push) Waiting to run
Details
Test Master / Unit tests (18.x) (push) Blocked by required conditions
Details
Test Master / Unit tests (20.x) (push) Blocked by required conditions
Details
Test Master / Unit tests (22.4) (push) Blocked by required conditions
Details
Test Master / Lint (push) Blocked by required conditions
Details
Test Master / Notify Slack on failure (push) Blocked by required conditions
Details
Benchmark Docker Image CI / build (push) Waiting to run
Details

Browse source
This commit is contained in:
Iván Ovejero 2024-09-03 17:58:26 +02:00 committed by GitHub
parent 2ea2bfe762
commit 36177b0943
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/cli/src/webhooks/__tests__/webhook.service.test.ts
View file

@ -179,12 +179,12 @@ describe('WebhookService', () => {
}); });
describe('createWebhook()', () => { describe('createWebhook()', () => {
test('should create the webhook', async () => { test('should store webhook in DB', async () => {
const mockWebhook = createWebhook('GET', 'user/:id'); const mockWebhook = createWebhook('GET', 'user/:id');
await webhookService.storeWebhook(mockWebhook); await webhookService.storeWebhook(mockWebhook);
expect(webhookRepository.insert).toHaveBeenCalledWith(mockWebhook); expect(webhookRepository.upsert).toHaveBeenCalledWith(mockWebhook, ['method', 'webhookPath']);
}); });
}); });
}); });

2
packages/cli/src/webhooks/webhook.service.ts
View file

@ -93,7 +93,7 @@ export class WebhookService {
async storeWebhook(webhook: WebhookEntity) { async storeWebhook(webhook: WebhookEntity) {
void this.cacheService.set(webhook.cacheKey, webhook); void this.cacheService.set(webhook.cacheKey, webhook);
return await this.webhookRepository.insert(webhook); await this.webhookRepository.upsert(webhook, ['method', 'webhookPath']);
} }
createWebhook(data: Partial<WebhookEntity>) { createWebhook(data: Partial<WebhookEntity>) {