From 36193451692b878cea703e3a743d9ac8f3ba5086 Mon Sep 17 00:00:00 2001 From: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com> Date: Tue, 8 Aug 2023 17:00:25 +0200 Subject: [PATCH] feat: Clean up onboarding experiment (#6873) * feat: Clean up onboarding experiment * chore: clean up --- packages/editor-ui/src/constants.ts | 8 +------- packages/editor-ui/src/stores/posthog.store.ts | 11 +---------- packages/editor-ui/src/stores/segment.store.ts | 11 ----------- 3 files changed, 2 insertions(+), 28 deletions(-) diff --git a/packages/editor-ui/src/constants.ts b/packages/editor-ui/src/constants.ts index 0b35c36958..ff62d1eb21 100644 --- a/packages/editor-ui/src/constants.ts +++ b/packages/editor-ui/src/constants.ts @@ -532,13 +532,7 @@ export const TEMPLATES_EXPERIMENT = { variantIds: ['1932', '1930', '1931', '1933', '1750', '1748', '1435'], }; -export const ONBOARDING_EXPERIMENT = { - name: '004_checklist', - control: 'control', - variant: 'variant', -}; - -export const EXPERIMENTS_TO_TRACK = [TEMPLATES_EXPERIMENT.name, ONBOARDING_EXPERIMENT.name]; +export const EXPERIMENTS_TO_TRACK = [TEMPLATES_EXPERIMENT.name]; export const NODE_TYPES_EXCLUDED_FROM_OUTPUT_NAME_APPEND = [FILTER_NODE_TYPE]; diff --git a/packages/editor-ui/src/stores/posthog.store.ts b/packages/editor-ui/src/stores/posthog.store.ts index 1626437f97..78920959f9 100644 --- a/packages/editor-ui/src/stores/posthog.store.ts +++ b/packages/editor-ui/src/stores/posthog.store.ts @@ -6,11 +6,7 @@ import { useSegment } from '@/stores/segment.store'; import { useRootStore } from '@/stores/n8nRoot.store'; import { useSettingsStore } from '@/stores/settings.store'; import type { FeatureFlags } from 'n8n-workflow'; -import { - EXPERIMENTS_TO_TRACK, - LOCAL_STORAGE_EXPERIMENT_OVERRIDES, - ONBOARDING_EXPERIMENT, -} from '@/constants'; +import { EXPERIMENTS_TO_TRACK, LOCAL_STORAGE_EXPERIMENT_OVERRIDES } from '@/constants'; import { useTelemetryStore } from './telemetry.store'; import { debounce } from 'lodash-es'; @@ -22,7 +18,6 @@ export const usePostHog = defineStore('posthog', () => { const usersStore = useUsersStore(); const settingsStore = useSettingsStore(); const telemetryStore = useTelemetryStore(); - const segmentStore = useSegment(); const rootStore = useRootStore(); const featureFlags: Ref = ref(null); @@ -165,10 +160,6 @@ export const usePostHog = defineStore('posthog', () => { }); trackedDemoExp.value[name] = variant; - - if (name === ONBOARDING_EXPERIMENT.name && variant === ONBOARDING_EXPERIMENT.variant) { - segmentStore.showAppCuesChecklist(); - } }; return { diff --git a/packages/editor-ui/src/stores/segment.store.ts b/packages/editor-ui/src/stores/segment.store.ts index 0b95f690e0..6b6eeb70b5 100644 --- a/packages/editor-ui/src/stores/segment.store.ts +++ b/packages/editor-ui/src/stores/segment.store.ts @@ -13,7 +13,6 @@ import { useWorkflowsStore } from '@/stores/workflows.store'; import { useNodeTypesStore } from '@/stores/nodeTypes.store'; const EVENTS = { - SHOW_CHECKLIST: 'Show checklist', ADDED_MANUAL_TRIGGER: 'User added manual trigger', ADDED_SCHEDULE_TRIGGER: 'User added schedule trigger', ADDED_DATA_TRIGGER: 'User added data trigger', @@ -35,15 +34,6 @@ export const useSegment = defineStore('segment', () => { } }; - const showAppCuesChecklist = () => { - const isInIframe = window.location !== window.parent.location; - if (isInIframe) { - return; - } - - track(EVENTS.SHOW_CHECKLIST); - }; - const trackAddedTrigger = (nodeTypeName: string) => { if (!nodeTypesStore.isTriggerNode(nodeTypeName)) { return; @@ -123,7 +113,6 @@ export const useSegment = defineStore('segment', () => { }; return { - showAppCuesChecklist, track, trackAddedTrigger, trackSuccessfulWorkflowExecution,