mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 04:34:06 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(editor): Fix remote options fetching on every keystroke (#7320)

Browse source 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Milorad FIlipović 2023-10-12 14:18:35 +02:00 committed by GitHub
parent 77039044eb
commit 367255ab2c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 20 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cypress/e2e/26-resource-locator.cy.ts
View file

@ -71,7 +71,7 @@ describe('Resource Locator', () => {
.findChildByTestId('rlc-item')
.should('have.length', 5);
ndv.actions.setInvalidExpression('fieldId');
ndv.actions.setInvalidExpression({ fieldName: 'fieldId' });
ndv.getters.container().click(); // remove focus from input, hide expression preview

4
cypress/e2e/28-resource-mapper.cy.ts
View file

@ -19,7 +19,7 @@ describe('Resource Mapper', () => {
.findChildByTestId('parameter-input')
.should('have.length', 3);
ndv.actions.setInvalidExpression('fieldId');
ndv.actions.setInvalidExpression({ fieldName: 'fieldId' });
ndv.actions.refreshResourceMapperColumns();
ndv.getters.resourceMapperFieldsContainer().should('not.exist');
@ -36,7 +36,7 @@ describe('Resource Mapper', () => {
.findChildByTestId('parameter-input')
.should('have.length', 3);
ndv.actions.setInvalidExpression('otherField');
ndv.actions.setInvalidExpression({ fieldName: 'otherField' });
ndv.actions.refreshResourceMapperColumns();
ndv.getters

17
cypress/e2e/5-ndv.cy.ts
View file

@ -297,15 +297,15 @@ describe('NDV', () => {
ndv.getters.parameterInput('remoteOptions').click();
getVisibleSelect().find('.el-select-dropdown__item').should('have.length', 3);
ndv.actions.setInvalidExpression('fieldId');
ndv.actions.setInvalidExpression({ fieldName: 'fieldId', delay: 100 });
ndv.getters.container().click(); // remove focus from input, hide expression preview
ndv.getters.parameterInput('remoteOptions').click();
getPopper().should('not.be.visible');
ndv.getters.parameterInputIssues('remoteOptions').realHover();
getVisiblePopper().should('include.text', `node doesn't exist`);
// Remote options dropdown should not be visible
ndv.getters.parameterInput('remoteOptions').find('.el-select').should('not.exist');
});
it('should retrieve remote options when non-required params throw errors', () => {
@ -315,7 +315,7 @@ describe('NDV', () => {
getVisibleSelect().find('.el-select-dropdown__item').should('have.length', 3);
ndv.getters.parameterInput('remoteOptions').click();
ndv.actions.setInvalidExpression('otherField');
ndv.actions.setInvalidExpression({ fieldName: 'otherField', delay: 50 });
ndv.getters.container().click(); // remove focus from input, hide expression preview
@ -356,4 +356,13 @@ describe('NDV', () => {
});
ndv.getters.nodeExecuteButton().should('be.visible');
});
it('should not retrieve remote options when a parameter value changes', () => {
cy.intercept('/rest/node-parameter-options?**', cy.spy().as('fetchParameterOptions'));
workflowPage.actions.addInitialNodeToCanvas('E2e Test', { action: 'Remote Options' });
// Type something into the field
ndv.actions.typeIntoParameterInput('otherField', 'test');
// Should call the endpoint only once (on mount), not for every keystroke
cy.get('@fetchParameterOptions').should('have.been.calledOnce');
});
});

5
cypress/pages/ndv.ts
View file

@ -114,7 +114,7 @@ export class NDV extends BasePage {
typeIntoParameterInput: (
parameterName: string,
content: string,
opts?: { parseSpecialCharSequences: boolean },
opts?: { parseSpecialCharSequences: boolean, delay?: number },
) => {
this.getters.parameterInput(parameterName).type(content, opts);
},
@ -199,10 +199,11 @@ export class NDV extends BasePage {
getVisiblePopper().find('li').last().click();
},
setInvalidExpression: (fieldName: string, invalidExpression?: string) => {
setInvalidExpression: ({ fieldName, invalidExpression, delay }: { fieldName: string, invalidExpression?: string, delay?: number }) => {
this.actions.typeIntoParameterInput(fieldName, '=');
this.actions.typeIntoParameterInput(fieldName, invalidExpression ?? "{{ $('unknown')", {
parseSpecialCharSequences: false,
delay,
});
this.actions.validateExpressionPreview(fieldName, `node doesn't exist`);
},

2
packages/editor-ui/src/components/ParameterInput.vue
View file

@ -1253,7 +1253,7 @@ export default defineComponent({
() => {
void this.loadRemoteParameterOptions();
},
{ deep: true, immediate: true },
{ immediate: true },
);
}