mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor(editor): Add skip option to activation modal (#6092)

Browse source 
⚡ Add skip option to activation modal
This commit is contained in:
Iván Ovejero 2023-04-27 21:21:53 +02:00 committed by GitHub
parent af097ae22c
commit 39b544271d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
cypress/e2e/22-user-activation-modal.cy.ts
View file

@ -57,6 +57,7 @@ describe('User activation survey', () => {
cy.wait(['@getWorkflows', '@getCredentials', '@getActive']); cy.wait(['@getWorkflows', '@getCredentials', '@getActive']);
userActivationSurveyModal.getters.modalContainer().should('be.visible'); userActivationSurveyModal.getters.modalContainer().should('be.visible');
userActivationSurveyModal.getters.feedbackInput().should('be.visible'); userActivationSurveyModal.getters.feedbackInput().should('be.visible');
userActivationSurveyModal.getters.skipButton().should('be.visible');
userActivationSurveyModal.getters.feedbackInput().type('testing'); userActivationSurveyModal.getters.feedbackInput().type('testing');
userActivationSurveyModal.getters.feedbackInput().should('have.value', 'testing'); userActivationSurveyModal.getters.feedbackInput().should('have.value', 'testing');
userActivationSurveyModal.getters.sendFeedbackButton().click(); userActivationSurveyModal.getters.sendFeedbackButton().click();

1
cypress/pages/modals/user-activation-survey-modal.ts
View file

@ -5,5 +5,6 @@ export class UserActivationSurveyModal extends BasePage {
modalContainer: () => cy.getByTestId('userActivationSurvey-modal').last(), modalContainer: () => cy.getByTestId('userActivationSurvey-modal').last(),
feedbackInput: () => cy.getByTestId('activation-feedback-input').find('textarea'), feedbackInput: () => cy.getByTestId('activation-feedback-input').find('textarea'),
sendFeedbackButton: () => cy.getByTestId('send-activation-feedback-button'), sendFeedbackButton: () => cy.getByTestId('send-activation-feedback-button'),
skipButton: () => cy.getByTestId('skip-button'),
}; };
} }

11
packages/editor-ui/src/components/UserActivationSurveyModal.vue
View file

@ -47,6 +47,13 @@
</template> </template>
<template #footer> <template #footer>
<div :class="$style.modalFooter"> <div :class="$style.modalFooter">
<n8n-button
size="large"
type="secondary"
data-test-id="skip-button"
:label="locale.baseText('userActivationSurveyModal.form.button.skip')"
@click="onSkip"
/>
<n8n-button <n8n-button
:disabled="!hasAnyChanges" :disabled="!hasAnyChanges"
@click="onShareFeedback" @click="onShareFeedback"
@ -100,6 +107,10 @@ const onShareFeedback = () => {
modalBus.emit('close'); modalBus.emit('close');
}; };
const onSkip = () => {
modalBus.emit('close');
};
const getCurrentSettings = () => { const getCurrentSettings = () => {
return userStore.currentUser?.settings; return userStore.currentUser?.settings;
}; };

1
packages/editor-ui/src/plugins/i18n/locales/en.json
View file

@ -1806,6 +1806,7 @@
"userActivationSurveyModal.description.savedTime": "for the first time. Looks like n8n just saved you some time! Can you help us make n8n even better and answer the following question?", "userActivationSurveyModal.description.savedTime": "for the first time. Looks like n8n just saved you some time! Can you help us make n8n even better and answer the following question?",
"userActivationSurveyModal.form.label": "What almost stopped you from creating this workflow?", "userActivationSurveyModal.form.label": "What almost stopped you from creating this workflow?",
"userActivationSurveyModal.form.button.shareFeedback": "Share feedback", "userActivationSurveyModal.form.button.shareFeedback": "Share feedback",
"userActivationSurveyModal.form.button.skip": "Skip",
"userActivationSurveyModal.sharedFeedback.success": "Thanks for your feedback", "userActivationSurveyModal.sharedFeedback.success": "Thanks for your feedback",
"userActivationSurveyModal.sharedFeedback.error": "Problem sharing feedback, try again", "userActivationSurveyModal.sharedFeedback.error": "Problem sharing feedback, try again",
"sso.login.divider": "or", "sso.login.divider": "or",