mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-14 08:34:07 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

wip: fix lint issue, more tests

Browse source
This commit is contained in:
Eugene Molodkin 2024-11-11 16:15:03 +01:00
parent bc470baee0
commit 3a4fd24d19
No known key found for this signature in database
2 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/cli/src/evaluation/test-definition.service.ee.ts
View file

@ -83,7 +83,7 @@ export class TestDefinitionService {
return await this.testDefinitionRepository.save(test);
}
async update(id: number, attrs: TestDefinitionLike, accessibleWorkflowIds: string[]) {
async update(id: number, attrs: TestDefinitionLike) {
if (attrs.name) {
const updatedTest = this.toEntity(attrs);
await validateEntity(updatedTest);

15
packages/cli/test/integration/evaluation/test-definitions.api.test.ts
View file

@ -223,6 +223,21 @@ describe('PATCH /evaluation/test-definitions/:id', () => {
expect(resp.body.data.name).toBe('updated-test');
});
test('should return 404 if user has no access to the workflow', async () => {
const newTest = Container.get(TestDefinitionRepository).create({
name: 'test',
workflow: { id: otherWorkflow.id },
});
await Container.get(TestDefinitionRepository).save(newTest);
const resp = await authOwnerAgent.patch(`/evaluation/test-definitions/${newTest.id}`).send({
name: 'updated-test',
});
expect(resp.statusCode).toBe(404);
expect(resp.body.message).toBe('Test definition not found');
});
test('should update test definition with evaluation workflow', async () => {
const newTest = Container.get(TestDefinitionRepository).create({
name: 'test',