mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(editor): Fix NDV close after using input select (#7544)

Browse source
This commit is contained in:
Csaba Tuncsik 2023-10-30 13:44:19 +01:00 committed by GitHub
parent 784b43330b
commit 3b5e181e66
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 14 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
cypress/e2e/5-ndv.cy.ts
View file

@ -42,7 +42,7 @@ describe('NDV', () => {
ndv.getters.outputDisplayMode().should('have.length.at.least', 1).and('be.visible'); ndv.getters.outputDisplayMode().should('have.length.at.least', 1).and('be.visible');
}); });
it('should change input', () => { it('should change input and go back to canvas', () => {
cy.createFixtureWorkflow('NDV-test-select-input.json', `NDV test select input ${uuid()}`); cy.createFixtureWorkflow('NDV-test-select-input.json', `NDV test select input ${uuid()}`);
workflowPage.actions.zoomToFit(); workflowPage.actions.zoomToFit();
workflowPage.getters.canvasNodes().last().dblclick(); workflowPage.getters.canvasNodes().last().dblclick();
@ -50,6 +50,9 @@ describe('NDV', () => {
ndv.getters.inputOption().last().click(); ndv.getters.inputOption().last().click();
ndv.getters.inputDataContainer().find('[class*=schema_]').should('exist'); ndv.getters.inputDataContainer().find('[class*=schema_]').should('exist');
ndv.getters.inputDataContainer().should('contain', 'start'); ndv.getters.inputDataContainer().should('contain', 'start');
ndv.getters.backToCanvas().click();
ndv.getters.container().should('not.be.visible');
cy.shouldNotHaveConsoleErrors();
}); });
it('should show correct validation state for resource locator params', () => { it('should show correct validation state for resource locator params', () => {

7
cypress/support/commands.ts
View file

@ -161,3 +161,10 @@ Cypress.Commands.add('draganddrop', (draggableSelector, droppableSelector) => {
} }
}); });
}); });
Cypress.Commands.add('shouldNotHaveConsoleErrors', () => {
cy.window().then((win) => {
const spy = cy.spy(win.console, 'error');
cy.wrap(spy).should('not.have.been.called');
});
});

1
cypress/support/index.ts
View file

@ -37,6 +37,7 @@ declare global {
options?: { abs?: boolean; index?: number; realMouse?: boolean }, options?: { abs?: boolean; index?: number; realMouse?: boolean },
): void; ): void;
draganddrop(draggableSelector: string, droppableSelector: string): void; draganddrop(draggableSelector: string, droppableSelector: string): void;
shouldNotHaveConsoleErrors(): void;
} }
} }
} }

4
packages/editor-ui/src/components/NodeDetailsView.vue
View file

@ -344,7 +344,7 @@ export default defineComponent({
return Math.min(this.runOutputIndex, this.maxOutputRun); return Math.min(this.runOutputIndex, this.maxOutputRun);
}, },
maxInputRun(): number { maxInputRun(): number {
if (this.inputNode === null && this.activeNode === null) { if (this.inputNode === null || this.activeNode === null) {
return 0; return 0;
} }
@ -355,7 +355,7 @@ export default defineComponent({
const runData: IRunData | null = this.workflowRunData; const runData: IRunData | null = this.workflowRunData;
if (outputs.filter((output) => output !== NodeConnectionType.Main).length) { if (outputs.some((output) => output !== NodeConnectionType.Main)) {
node = this.activeNode; node = this.activeNode;
} }