mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-02-21 02:56:40 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(Invoice Ninja Node): Fix line items not being correctly set for quotes and invoices (#5304)

Browse source
This commit is contained in:
Paras Daryanani 2023-02-02 12:26:56 +00:00 committed by GitHub
parent 04c058a34e
commit 3b5e1d127f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 28 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
packages/nodes-base/nodes/InvoiceNinja/InvoiceNinja.node.ts
View file

@ -472,16 +472,26 @@ export class InvoiceNinja implements INodeType {
cost: itemValue.cost as number, cost: itemValue.cost as number,
notes: itemValue.description as string, notes: itemValue.description as string,
product_key: itemValue.service as string, product_key: itemValue.service as string,
qty: itemValue.hours as number,
tax_rate1: itemValue.taxRate1 as number, tax_rate1: itemValue.taxRate1 as number,
tax_rate2: itemValue.taxRate2 as number, tax_rate2: itemValue.taxRate2 as number,
tax_name1: itemValue.taxName1 as string, tax_name1: itemValue.taxName1 as string,
tax_name2: itemValue.taxName2 as string, tax_name2: itemValue.taxName2 as string,
}; };
if (apiVersion === 'v4') {
item.qty = itemValue.hours as number;
}
if (apiVersion === 'v5') {
item.quantity = itemValue.hours as number;
}
invoiceItems.push(item); invoiceItems.push(item);
} }
if (apiVersion === 'v4') {
body.invoice_items = invoiceItems; body.invoice_items = invoiceItems;
} }
if (apiVersion === 'v5') {
body.line_items = invoiceItems;
}
}
responseData = await invoiceNinjaApiRequest.call( responseData = await invoiceNinjaApiRequest.call(
this, this,
'POST', 'POST',
@ -902,16 +912,26 @@ export class InvoiceNinja implements INodeType {
cost: itemValue.cost as number, cost: itemValue.cost as number,
notes: itemValue.description as string, notes: itemValue.description as string,
product_key: itemValue.service as string, product_key: itemValue.service as string,
qty: itemValue.hours as number,
tax_rate1: itemValue.taxRate1 as number, tax_rate1: itemValue.taxRate1 as number,
tax_rate2: itemValue.taxRate2 as number, tax_rate2: itemValue.taxRate2 as number,
tax_name1: itemValue.taxName1 as string, tax_name1: itemValue.taxName1 as string,
tax_name2: itemValue.taxName2 as string, tax_name2: itemValue.taxName2 as string,
}; };
if (apiVersion === 'v4') {
item.qty = itemValue.hours as number;
}
if (apiVersion === 'v5') {
item.quantity = itemValue.hours as number;
}
invoiceItems.push(item); invoiceItems.push(item);
} }
if (apiVersion === 'v4') {
body.invoice_items = invoiceItems; body.invoice_items = invoiceItems;
} }
if (apiVersion === 'v5') {
body.line_items = invoiceItems;
}
}
responseData = await invoiceNinjaApiRequest.call( responseData = await invoiceNinjaApiRequest.call(
this, this,
'POST', 'POST',

2
packages/nodes-base/nodes/InvoiceNinja/QuoteInterface.ts
View file

@ -3,6 +3,7 @@ export interface IItem {
notes?: string; notes?: string;
product_key?: string; product_key?: string;
qty?: number; qty?: number;
quantity?: number;
tax_rate1?: number; tax_rate1?: number;
tax_rate2?: number; tax_rate2?: number;
tax_name1?: string; tax_name1?: string;
@ -20,6 +21,7 @@ export interface IQuote {
email?: string; email?: string;
invoice_date?: string; invoice_date?: string;
invoice_items?: IItem[]; invoice_items?: IItem[];
line_items?: IItem[];
invoice_number?: string; invoice_number?: string;
invoice_status_id?: number; invoice_status_id?: number;
is_amount_discount?: boolean; is_amount_discount?: boolean;

2
packages/nodes-base/nodes/InvoiceNinja/invoiceInterface.ts
View file

@ -3,6 +3,7 @@ export interface IItem {
notes?: string; notes?: string;
product_key?: string; product_key?: string;
qty?: number; qty?: number;
quantity?: number;
tax_rate1?: number; tax_rate1?: number;
tax_rate2?: number; tax_rate2?: number;
tax_name1?: string; tax_name1?: string;
@ -20,6 +21,7 @@ export interface IInvoice {
due_date?: string; due_date?: string;
invoice_date?: string; invoice_date?: string;
invoice_items?: IItem[]; invoice_items?: IItem[];
line_items?: IItem[];
invoice_number?: string; invoice_number?: string;
invoice_status_id?: number; invoice_status_id?: number;
is_amount_discount?: boolean; is_amount_discount?: boolean;