mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-24 04:04:06 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix(editor): Prevent saving workflow while another save is in progress (#9048)

Browse source
This commit is contained in:
Milorad FIlipović 2024-04-04 09:59:02 +02:00 committed by GitHub
parent 744327c20d
commit 3c9a1d2da3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 23 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
cypress/e2e/7-workflow-actions.cy.ts
View file

@ -108,6 +108,23 @@ describe('Workflow Actions', () => {
cy.wait('@saveWorkflow'); cy.wait('@saveWorkflow');
cy.wrap(null).then(() => expect(interceptCalledCount).to.eq(1)); cy.wrap(null).then(() => expect(interceptCalledCount).to.eq(1));
}); });
it('should not save workflow twice when save is in progress', () => {
// This happens when users click save button from workflow name input
// In this case blur on the input saves the workflow and then click on the button saves it again
WorkflowPage.actions.visit();
WorkflowPage.getters.workflowNameInput().invoke('val').then((oldName) => {
WorkflowPage.getters.workflowNameInputContainer().click();
WorkflowPage.getters.workflowNameInput().type('{selectall}');
WorkflowPage.getters.workflowNameInput().type('Test');
WorkflowPage.getters.saveButton().click();
WorkflowPage.getters.workflowNameInput().should('have.value', 'Test');
cy.visit(WorkflowPages.url);
// There should be no workflow with the old name (duplicate save)
WorkflowPages.getters.workflowCards().contains(String(oldName)).should('not.exist');
});
});
it('should copy nodes', () => { it('should copy nodes', () => {
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME); WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
WorkflowPage.actions.addNodeToCanvas(CODE_NODE_NAME); WorkflowPage.actions.addNodeToCanvas(CODE_NODE_NAME);

7
packages/editor-ui/src/components/MainHeader/WorkflowDetails.vue
View file

@ -388,6 +388,10 @@ export default defineComponent({
}, },
methods: { methods: {
async onSaveButtonClick() { async onSaveButtonClick() {
// If the workflow is saving, do not allow another save
if (this.isWorkflowSaving) {
return;
}
let currentId = undefined; let currentId = undefined;
if (this.currentWorkflowId !== PLACEHOLDER_EMPTY_WORKFLOW_ID) { if (this.currentWorkflowId !== PLACEHOLDER_EMPTY_WORKFLOW_ID) {
currentId = this.currentWorkflowId; currentId = this.currentWorkflowId;
@ -497,11 +501,12 @@ export default defineComponent({
cb(true); cb(true);
return; return;
} }
this.uiStore.addActiveAction('workflowSaving');
const saved = await this.workflowHelpers.saveCurrentWorkflow({ name }); const saved = await this.workflowHelpers.saveCurrentWorkflow({ name });
if (saved) { if (saved) {
this.isNameEditEnabled = false; this.isNameEditEnabled = false;
} }
this.uiStore.removeActiveAction('workflowSaving');
cb(saved); cb(saved);
}, },
async handleFileImport(): Promise<void> { async handleFileImport(): Promise<void> {