mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

🐛 Fix issue getting binary data when filesystem mode is used - Move Binary Data (#2727)

Browse source 
* 🐛 Fix issue getting binary data when filesystem mode is used

* ⚡ Simplifications

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
This commit is contained in:
Ricardo Espinoza 2022-01-28 02:46:30 -05:00 committed by GitHub
parent 48b2a0b857
commit 3cde6bd426
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
packages/nodes-base/nodes/MoveBinaryData/MoveBinaryData.node.ts
View file

@ -394,18 +394,23 @@ export class MoveBinaryData implements INodeType {
} }
const encoding = (options.encoding as string) || 'utf8'; const encoding = (options.encoding as string) || 'utf8';
let convertedValue = value.data;
const buffer = await this.helpers.getBinaryDataBuffer(itemIndex, sourceKey);
let convertedValue: string;
if (setAllData === true) { if (setAllData === true) {
// Set the full data // Set the full data
convertedValue = iconv.decode(Buffer.from(convertedValue, BINARY_ENCODING), encoding, { stripBOM: options.stripBOM as boolean }); convertedValue = iconv.decode(buffer, encoding, { stripBOM: options.stripBOM as boolean });
newItem.json = JSON.parse(convertedValue); newItem.json = JSON.parse(convertedValue);
} else { } else {
// Does get added to existing data so copy it first // Does get added to existing data so copy it first
newItem.json = JSON.parse(JSON.stringify(item.json)); newItem.json = JSON.parse(JSON.stringify(item.json));
if (options.keepAsBase64 !== true) { if (options.keepAsBase64 !== true) {
convertedValue = iconv.decode(Buffer.from(convertedValue, BINARY_ENCODING), encoding, { stripBOM: options.stripBOM as boolean }); convertedValue = iconv.decode(buffer, encoding, { stripBOM: options.stripBOM as boolean });
} else {
convertedValue = Buffer.from(buffer).toString(BINARY_ENCODING);
} }
if (options.jsonParse) { if (options.jsonParse) {