🔀 Merge branch 'RicardoE105-fix/rocketchat-node'

packages/cli/BREAKING-CHANGES.md

@@ -2,6 +2,23 @@
 
 This list shows all the versions which include breaking changes and how to upgrade
 
+## 0.37.0
+
+### What changed?
+
+To make it possible to support also Rocketchat on-premise the credentials had to be changed.
+The `subdomain` parameter had to get renamed to `domain`.
+
+### When is action necessary?
+
+When you currently use the Rocketchat-Node.
+
+### How to upgrade:
+
+Open the Rocketchat credentials and fill the parameter `domain`. If you had previously the
+subdomain "example" set you have to set now "https://example.rocket.chat".
+
+
 ## 0.19.0
 
 ### What changed?

packages/nodes-base/credentials/RocketchatApi.credentials.ts

@@ -21,11 +21,11 @@ export class RocketchatApi implements ICredentialType {
 			default: '',
 		},
 		{
-			displayName: 'Sub Domain',
-			name: 'subdomain',
+			displayName: 'Domain',
+			name: 'domain',
 			type: 'string' as NodePropertyTypes,
 			default: '',
-			placeholder: 'n8n'
+			placeholder: 'https://n8n.rocket.chat',
 		},
 	];
 }

packages/nodes-base/nodes/Rocketchat/GenericFunctions.ts

@@ -13,16 +13,14 @@ export async function rocketchatApiRequest(this: IHookFunctions | IExecuteFuncti
 		throw new Error('No credentials got returned!');
 	}
 
-	const headerWithAuthentication = Object.assign({}, headers, 
+	const headerWithAuthentication = Object.assign({}, headers,
 		{ 'X-Auth-Token': credentials.authKey, 'X-User-Id': credentials.userId   });
 
-	const endpoint = 'rocket.chat/api/v1';
-
 	const options: OptionsWithUri = {
 		headers: headerWithAuthentication,
 		method,
 		body,
-		uri: `https://${credentials.subdomain}.${endpoint}${resource}.${operation}`,
+		uri: `${credentials.domain}${resource}.${operation}`,
 		json: true
 	};