🐛 Fix performance and crashes with latest updates (#1524)

* Removing unnecessary data from process communication

* Wrapping progress save in a try ... catch block to prevent crashes

* Migration to fix mysql problems with big data on executions

* ⚡ Minor formatting fixes

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>

packages/cli/src/WorkflowExecuteAdditionalData.ts

@@ -230,6 +230,7 @@ export function hookFunctionsPreExecute(parentProcessMode?: string): IWorkflowEx
 					return;
 				}
 
+				try {
 					const execution = await Db.collections.Execution!.findOne(this.executionId);
 
 					if (execution === undefined) {
@@ -278,6 +279,15 @@ export function hookFunctionsPreExecute(parentProcessMode?: string): IWorkflowEx
 					const flattenedExecutionData = ResponseHelper.flattenExecutionData(fullExecutionData);
 
 					await Db.collections.Execution!.update(this.executionId, flattenedExecutionData as IExecutionFlattedDb);
+				} catch (err) {
+					// TODO: Improve in the future!
+					// Errors here might happen because of database access
+					// For busy machines, we may get "Database is locked" errors.
+
+					// We do this to prevent crashes and executions ending in `unknown` state.
+					console.log(`Failed saving execution progress to database for execution ID ${this.executionId}`, err);
+				}
+
 			},
 		],
 	};

packages/cli/src/WorkflowRunnerProcess.ts

@@ -174,8 +174,8 @@ export class WorkflowRunnerProcess {
 				},
 			],
 			nodeExecuteAfter: [
-				async (nodeName: string, data: ITaskData, executionData: IRunExecutionData): Promise<void> => {
+				async (nodeName: string, data: ITaskData): Promise<void> => {
-					this.sendHookToParentProcess('nodeExecuteAfter', [nodeName, data, executionData]);
+					this.sendHookToParentProcess('nodeExecuteAfter', [nodeName, data]);
 				},
 			],
 			workflowExecuteBefore: [

packages/cli/src/databases/mysqldb/migrations/1615306975123-ChangeDataSize.ts

@@ -0,0 +1,18 @@
+import { MigrationInterface, QueryRunner } from 'typeorm';
+import * as config from '../../../../config';
+
+export class ChangeDataSize1615306975123 implements MigrationInterface {
+	name = 'ChangeDataSize1615306975123';
+
+	async up(queryRunner: QueryRunner): Promise<void> {
+		const tablePrefix = config.get('database.tablePrefix');
+
+		await queryRunner.query('ALTER TABLE `' + tablePrefix + 'execution_entity` MODIFY COLUMN `data` MEDIUMTEXT NOT NULL');
+	}
+
+	async down(queryRunner: QueryRunner): Promise<void> {
+		const tablePrefix = config.get('database.tablePrefix');
+
+		await queryRunner.query('ALTER TABLE `' + tablePrefix + 'execution_entity` MODIFY COLUMN `data` TEXT NOT NULL');
+	}
+}

packages/cli/src/databases/mysqldb/migrations/index.ts

@@ -3,6 +3,7 @@ import { WebhookModel1592447867632 } from './1592447867632-WebhookModel';
 import { CreateIndexStoppedAt1594902918301 } from './1594902918301-CreateIndexStoppedAt';
 import { AddWebhookId1611149998770 } from './1611149998770-AddWebhookId';
 import { MakeStoppedAtNullable1607431743767 } from './1607431743767-MakeStoppedAtNullable';
+import { ChangeDataSize1615306975123 } from './1615306975123-ChangeDataSize';
 
 export const mysqlMigrations = [
 	InitialMigration1588157391238,
@@ -10,4 +11,5 @@ export const mysqlMigrations = [
 	CreateIndexStoppedAt1594902918301,
 	AddWebhookId1611149998770,
 	MakeStoppedAtNullable1607431743767,
+	ChangeDataSize1615306975123,
 ];