mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-02-21 02:56:40 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(editor): Don't show toolsUnused notice if run had errors (#12529)

Browse source
This commit is contained in:
Charlie Kolb 2025-01-13 09:05:35 +01:00 committed by GitHub
parent c6b491cdbb
commit 3ec5b2850c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
packages/editor-ui/src/components/OutputPanel.vue
View file

@ -4,7 +4,6 @@ import {
NodeConnectionType, NodeConnectionType,
type IRunData, type IRunData,
type IRunExecutionData, type IRunExecutionData,
type NodeError,
type Workflow, type Workflow,
} from 'n8n-workflow'; } from 'n8n-workflow';
import RunData from './RunData.vue'; import RunData from './RunData.vue';
@ -120,14 +119,17 @@ const hasAiMetadata = computed(() => {
return false; return false;
}); });
const hasError = computed(() =>
Boolean(
workflowRunData.value &&
node.value &&
workflowRunData.value[node.value.name]?.[props.runIndex]?.error,
),
);
// Determine the initial output mode to logs if the node has an error and the logs are available // Determine the initial output mode to logs if the node has an error and the logs are available
const defaultOutputMode = computed<OutputType>(() => { const defaultOutputMode = computed<OutputType>(() => {
const hasError = return hasError.value && hasAiMetadata.value ? OUTPUT_TYPE.LOGS : OUTPUT_TYPE.REGULAR;
workflowRunData.value &&
node.value &&
(workflowRunData.value[node.value.name]?.[props.runIndex]?.error as NodeError);
return Boolean(hasError) && hasAiMetadata.value ? OUTPUT_TYPE.LOGS : OUTPUT_TYPE.REGULAR;
}); });
const isNodeRunning = computed(() => { const isNodeRunning = computed(() => {
@ -216,7 +218,7 @@ const canPinData = computed(() => {
}); });
const allToolsWereUnusedNotice = computed(() => { const allToolsWereUnusedNotice = computed(() => {
if (!node.value || runsCount.value === 0) return undefined; if (!node.value || runsCount.value === 0 || hasError.value) return undefined;
// With pinned data there's no clear correct answer for whether // With pinned data there's no clear correct answer for whether
// we should use historic or current parents, so we don't show the notice, // we should use historic or current parents, so we don't show the notice,