mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

test(editor): Add e2e tests for inline expression editor (#4936)

Browse source 
🧪 Add tests for inline expression editor
This commit is contained in:
Iván Ovejero 2022-12-15 15:36:28 +01:00 committed by GitHub
parent fe0f982437
commit 4208040495
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 77 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

66
cypress/e2e/11-inline-expression-editor.cy.ts Normal file
View file

@ -0,0 +1,66 @@
import { WorkflowPage as WorkflowPageClass } from '../pages/workflow';
const WorkflowPage = new WorkflowPageClass();
describe('Inline expression editor', () => {
before(() => {
cy.task('reset');
cy.skipSetup();
});
beforeEach(() => {
WorkflowPage.actions.visit();
WorkflowPage.actions.addInitialNodeToCanvas('Manual Trigger');
WorkflowPage.actions.addNodeToCanvas('Hacker News');
WorkflowPage.actions.openNodeNdv('Hacker News');
WorkflowPage.actions.openInlineExpressionEditor();
});
it('should resolve primitive resolvables', () => {
WorkflowPage.getters.inlineExpressionEditorInput().type('{{');
WorkflowPage.getters.inlineExpressionEditorInput().type('1 + 2');
WorkflowPage.getters.inlineExpressionEditorOutput().contains(/^3$/);
WorkflowPage.getters.inlineExpressionEditorInput().clear();
WorkflowPage.getters.inlineExpressionEditorInput().type('{{');
WorkflowPage.getters.inlineExpressionEditorInput().type('"ab');
WorkflowPage.getters.inlineExpressionEditorInput().type('{rightArrow}+');
WorkflowPage.getters.inlineExpressionEditorInput().type('"cd');
WorkflowPage.getters.inlineExpressionEditorOutput().contains(/^abcd$/);
WorkflowPage.getters.inlineExpressionEditorInput().clear();
WorkflowPage.getters.inlineExpressionEditorInput().type('{{');
WorkflowPage.getters.inlineExpressionEditorInput().type('true && false');
WorkflowPage.getters.inlineExpressionEditorOutput().contains(/^false$/);
});
it('should resolve object resolvables', () => {
WorkflowPage.getters.inlineExpressionEditorInput().type('{{');
WorkflowPage.getters.inlineExpressionEditorInput().type('{{} a: 1');
WorkflowPage.getters.inlineExpressionEditorOutput().contains(/^\[Object: \{"a":1\}\]$/);
WorkflowPage.getters.inlineExpressionEditorInput().clear();
WorkflowPage.getters.inlineExpressionEditorInput().type('{{');
WorkflowPage.getters.inlineExpressionEditorInput().type('{{} a: 1 }.a{del}{del}');
WorkflowPage.getters.inlineExpressionEditorOutput().contains(/^1$/);
});
it('should resolve array resolvables', () => {
WorkflowPage.getters.inlineExpressionEditorInput().type('{{');
WorkflowPage.getters.inlineExpressionEditorInput().type('[1, 2, 3');
WorkflowPage.getters.inlineExpressionEditorOutput().contains(/^\[Array: \[1,2,3\]\]$/);
WorkflowPage.getters.inlineExpressionEditorInput().clear();
WorkflowPage.getters.inlineExpressionEditorInput().type('{{');
WorkflowPage.getters.inlineExpressionEditorInput().type('[1, 2, 3');
WorkflowPage.getters.inlineExpressionEditorInput().type('{rightArrow}[0');
WorkflowPage.getters.inlineExpressionEditorOutput().contains(/^1$/);
});
it('should resolve $parameter[]', () => {
WorkflowPage.getters.inlineExpressionEditorInput().type('{{');
WorkflowPage.getters.inlineExpressionEditorInput().type('$parameter["operation');
WorkflowPage.getters.inlineExpressionEditorOutput().contains(/^get$/);
});
});

2
cypress/e2e/9-expression-editor-modal.cy.ts
View file

@ -13,7 +13,7 @@ describe('Expression editor modal', () => {
WorkflowPage.actions.addInitialNodeToCanvas('Manual Trigger'); WorkflowPage.actions.addInitialNodeToCanvas('Manual Trigger');
WorkflowPage.actions.addNodeToCanvas('Hacker News'); WorkflowPage.actions.addNodeToCanvas('Hacker News');
WorkflowPage.actions.openNodeNdv('Hacker News'); WorkflowPage.actions.openNodeNdv('Hacker News');
WorkflowPage.actions.openExpressionEditor(); WorkflowPage.actions.openExpressionEditorModal();
}); });
it('should resolve primitive resolvables', () => { it('should resolve primitive resolvables', () => {

9
cypress/pages/workflow.ts
View file

@ -58,6 +58,9 @@ export class WorkflowPage extends BasePage {
workflowSettingsTimeoutWorkflowSwitch: () => cy.getByTestId('workflow-settings-timeout-workflow'), workflowSettingsTimeoutWorkflowSwitch: () => cy.getByTestId('workflow-settings-timeout-workflow'),
workflowSettingsTimeoutForm: () => cy.getByTestId('workflow-settings-timeout-form'), workflowSettingsTimeoutForm: () => cy.getByTestId('workflow-settings-timeout-form'),
workflowSettingsSaveButton: () => cy.getByTestId('workflow-settings-save-button').find('button'), workflowSettingsSaveButton: () => cy.getByTestId('workflow-settings-save-button').find('button'),
inlineExpressionEditorInput: () => cy.getByTestId('inline-expression-editor-input'),
inlineExpressionEditorOutput: () => cy.getByTestId('inline-expression-editor-output'),
}; };
actions = { actions = {
visit: () => { visit: () => {
@ -79,10 +82,14 @@ export class WorkflowPage extends BasePage {
openNodeNdv: (nodeTypeName: string) => { openNodeNdv: (nodeTypeName: string) => {
this.getters.canvasNodeByName(nodeTypeName).dblclick(); this.getters.canvasNodeByName(nodeTypeName).dblclick();
}, },
openExpressionEditor: () => { openExpressionEditorModal: () => {
cy.contains('Expression').invoke('show').click(); cy.contains('Expression').invoke('show').click();
cy.getByTestId('expander').invoke('show').click(); cy.getByTestId('expander').invoke('show').click();
}, },
openInlineExpressionEditor: () => {
cy.contains('Expression').invoke('show').click();
this.getters.inlineExpressionEditorInput().click();
},
typeIntoParameterInput: (parameterName: string, content: string) => { typeIntoParameterInput: (parameterName: string, content: string) => {
this.getters.ndvParameterInput(parameterName).type(content); this.getters.ndvParameterInput(parameterName).type(content);
}, },

2
packages/editor-ui/src/components/InlineExpressionEditor/InlineExpressionEditorInput.vue
View file

@ -1,5 +1,5 @@
<template> <template>
<div ref="root" class="ph-no-capture"></div> <div ref="root" class="ph-no-capture" data-test-id="inline-expression-editor-input"></div>
</template> </template>
<script lang="ts"> <script lang="ts">

2
packages/editor-ui/src/components/InlineExpressionEditor/InlineExpressionEditorOutput.vue
View file

@ -1,5 +1,5 @@
<template> <template>
<div ref="root" class="ph-no-capture"></div> <div ref="root" class="ph-no-capture" data-test-id="inline-expression-editor-output"></div>
</template> </template>
<script lang="ts"> <script lang="ts">