From 42d2959f47f33defda4239a4d2fbba6927d98617 Mon Sep 17 00:00:00 2001 From: Ricardo Espinoza Date: Thu, 23 Jun 2022 13:44:25 -0400 Subject: [PATCH] fix: Fix issue with required optional parameters (#3577) --- packages/nodes-base/nodes/Cockpit/CollectionDescription.ts | 1 - packages/nodes-base/nodes/Freshdesk/Freshdesk.node.ts | 1 - packages/nodes-base/nodes/Ftp/Ftp.node.ts | 2 -- .../nodes/GoToWebinar/descriptions/WebinarDescription.ts | 1 - .../CloudNaturalLanguage/GoogleCloudNaturalLanguage.node.ts | 1 - packages/nodes-base/nodes/Google/Drive/GoogleDrive.node.ts | 4 ---- packages/nodes-base/nodes/Hubspot/DealDescription.ts | 1 - .../nodes/Lemlist/descriptions/ActivityDescription.ts | 1 - packages/nodes-base/nodes/Mailchimp/Mailchimp.node.ts | 1 - packages/nodes-base/nodes/MongoDb/mongo.node.options.ts | 1 - 10 files changed, 14 deletions(-) diff --git a/packages/nodes-base/nodes/Cockpit/CollectionDescription.ts b/packages/nodes-base/nodes/Cockpit/CollectionDescription.ts index 770845a90d..49abb74da7 100644 --- a/packages/nodes-base/nodes/Cockpit/CollectionDescription.ts +++ b/packages/nodes-base/nodes/Cockpit/CollectionDescription.ts @@ -147,7 +147,6 @@ export const collectionFields: INodeProperties[] = [ displayName: 'Populate', name: 'populate', type: 'boolean', - required: true, default: true, description: 'Whether to resolve linked collection items', }, diff --git a/packages/nodes-base/nodes/Freshdesk/Freshdesk.node.ts b/packages/nodes-base/nodes/Freshdesk/Freshdesk.node.ts index 7b9d281cec..6b452ebb6b 100644 --- a/packages/nodes-base/nodes/Freshdesk/Freshdesk.node.ts +++ b/packages/nodes-base/nodes/Freshdesk/Freshdesk.node.ts @@ -795,7 +795,6 @@ export class Freshdesk implements INodeType { displayName: 'Source', name: 'source', type: 'options', - required: true, options: [ { name: 'Chat', diff --git a/packages/nodes-base/nodes/Ftp/Ftp.node.ts b/packages/nodes-base/nodes/Ftp/Ftp.node.ts index 649d31068d..09a3f59ed9 100644 --- a/packages/nodes-base/nodes/Ftp/Ftp.node.ts +++ b/packages/nodes-base/nodes/Ftp/Ftp.node.ts @@ -167,7 +167,6 @@ export class Ftp implements INodeType { type: 'boolean', default: false, description: 'Whether folders can be deleted', - required: true, }, { displayName: 'Recursive', @@ -182,7 +181,6 @@ export class Ftp implements INodeType { type: 'boolean', default: false, description: 'Whether to remove all files and directories in target directory', - required: true, }, ], }, diff --git a/packages/nodes-base/nodes/GoToWebinar/descriptions/WebinarDescription.ts b/packages/nodes-base/nodes/GoToWebinar/descriptions/WebinarDescription.ts index cc21b9602d..e037ab1825 100644 --- a/packages/nodes-base/nodes/GoToWebinar/descriptions/WebinarDescription.ts +++ b/packages/nodes-base/nodes/GoToWebinar/descriptions/WebinarDescription.ts @@ -508,7 +508,6 @@ export const webinarFields: INodeProperties[] = [ displayName: 'Timezone Name or ID', name: 'timezone', type: 'options', - required: true, default: '', placeholder: '2020-12-11T09:00:00Z', description: 'Timezone where the webinar is to take place. Choose from the list, or specify an ID using an expression.', diff --git a/packages/nodes-base/nodes/Google/CloudNaturalLanguage/GoogleCloudNaturalLanguage.node.ts b/packages/nodes-base/nodes/Google/CloudNaturalLanguage/GoogleCloudNaturalLanguage.node.ts index e796bcdc65..1a8fb9432c 100644 --- a/packages/nodes-base/nodes/Google/CloudNaturalLanguage/GoogleCloudNaturalLanguage.node.ts +++ b/packages/nodes-base/nodes/Google/CloudNaturalLanguage/GoogleCloudNaturalLanguage.node.ts @@ -167,7 +167,6 @@ export class GoogleCloudNaturalLanguage implements INodeType { ], default: 'PLAIN_TEXT', description: 'The type of input document', - required: true, }, { displayName: 'Encoding Type', diff --git a/packages/nodes-base/nodes/Google/Drive/GoogleDrive.node.ts b/packages/nodes-base/nodes/Google/Drive/GoogleDrive.node.ts index aa28610ec3..b36a643eda 100644 --- a/packages/nodes-base/nodes/Google/Drive/GoogleDrive.node.ts +++ b/packages/nodes-base/nodes/Google/Drive/GoogleDrive.node.ts @@ -1020,7 +1020,6 @@ export class GoogleDrive implements INodeType { value: 'webViewLink', }, ], - required: true, default: [], description: 'The fields to return', }, @@ -1254,7 +1253,6 @@ export class GoogleDrive implements INodeType { value: 'webViewLink', }, ], - required: true, default: [], description: 'The fields to return', }, @@ -1423,7 +1421,6 @@ export class GoogleDrive implements INodeType { value: 'photos', }, ], - required: true, default: [], description: 'The spaces to operate on', }, @@ -1463,7 +1460,6 @@ export class GoogleDrive implements INodeType { description: 'All drives', }, ], - required: true, default: '', description: 'The corpora to operate on', }, diff --git a/packages/nodes-base/nodes/Hubspot/DealDescription.ts b/packages/nodes-base/nodes/Hubspot/DealDescription.ts index fe614225cc..9f6b8eee93 100644 --- a/packages/nodes-base/nodes/Hubspot/DealDescription.ts +++ b/packages/nodes-base/nodes/Hubspot/DealDescription.ts @@ -302,7 +302,6 @@ export const dealFields: INodeProperties[] = [ displayName: 'Deal Stage Name or ID', name: 'stage', type: 'options', - required: true, typeOptions: { loadOptionsMethod: 'getDealStages', }, diff --git a/packages/nodes-base/nodes/Lemlist/descriptions/ActivityDescription.ts b/packages/nodes-base/nodes/Lemlist/descriptions/ActivityDescription.ts index a9e60bb376..ddbbb4a3f9 100644 --- a/packages/nodes-base/nodes/Lemlist/descriptions/ActivityDescription.ts +++ b/packages/nodes-base/nodes/Lemlist/descriptions/ActivityDescription.ts @@ -91,7 +91,6 @@ export const activityFields: INodeProperties[] = [ displayName: 'Campaign Name or ID', name: 'campaignId', type: 'options', - required: true, default: '', typeOptions: { loadOptionsMethod: 'getCampaigns', diff --git a/packages/nodes-base/nodes/Mailchimp/Mailchimp.node.ts b/packages/nodes-base/nodes/Mailchimp/Mailchimp.node.ts index 6961199daa..343f81e4c6 100644 --- a/packages/nodes-base/nodes/Mailchimp/Mailchimp.node.ts +++ b/packages/nodes-base/nodes/Mailchimp/Mailchimp.node.ts @@ -1221,7 +1221,6 @@ export class Mailchimp implements INodeType { displayName: 'Status', name: 'status', type: 'options', - required: true, options: [ { name: 'Cleaned', diff --git a/packages/nodes-base/nodes/MongoDb/mongo.node.options.ts b/packages/nodes-base/nodes/MongoDb/mongo.node.options.ts index 78f0e534f4..0c2571c27f 100644 --- a/packages/nodes-base/nodes/MongoDb/mongo.node.options.ts +++ b/packages/nodes-base/nodes/MongoDb/mongo.node.options.ts @@ -159,7 +159,6 @@ export const nodeDescription: INodeTypeDescription = { }, default: '{}', placeholder: '{ "field": -1 }', - required: true, description: 'A JSON that defines the sort order of the result set', }, ],