mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-09 22:24:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(Linear Node): Fix issue with data not always being returned (#9273)

Browse source 
Co-authored-by: Michael Kret <michael.k@radency.com>
This commit is contained in:
Jon 2024-05-08 10:24:08 +01:00 committed by GitHub
parent 3860077f81
commit 435272b568
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 16 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
packages/nodes-base/nodes/Linear/GenericFunctions.ts
View file

@ -52,20 +52,30 @@ export function capitalizeFirstLetter(data: string) {
export async function linearApiRequestAllItems(
this: IHookFunctions | IExecuteFunctions | ILoadOptionsFunctions,
propertyName: string,
body: any = {},
limit?: number,
): Promise<any> {
const returnData: IDataObject[] = [];
let responseData;
body.variables.first = 50;
body.variables.first = limit && limit < 50 ? limit : 50;
body.variables.after = null;
const propertyPath = propertyName.split('.');
const nodesPath = [...propertyPath, 'nodes'];
const endCursorPath = [...propertyPath, 'pageInfo', 'endCursor'];
const hasNextPagePath = [...propertyPath, 'pageInfo', 'hasNextPage'];
do {
responseData = await linearApiRequest.call(this, body);
returnData.push.apply(returnData, get(responseData, [propertyName, 'nodes']) as IDataObject[]);
body.variables.after = get(responseData, [propertyName, 'pageInfo', 'endCursor']);
} while (get(responseData, [propertyName, 'pageInfo', 'hasNextPage']));
const nodes = get(responseData, nodesPath) as IDataObject[];
returnData.push(...nodes);
body.variables.after = get(responseData, endCursorPath);
if (limit && returnData.length >= limit) {
return returnData;
}
} while (get(responseData, hasNextPagePath));
return returnData;
}

1
packages/nodes-base/nodes/Linear/IssueDescription.ts
View file

@ -192,7 +192,6 @@ export const issueFields: INodeProperties[] = [
default: 50,
typeOptions: {
minValue: 1,
maxValue: 300,
},
displayOptions: {
show: {

4
packages/nodes-base/nodes/Linear/Linear.node.ts
View file

@ -272,9 +272,7 @@ export class Linear implements INodeType {
responseData = await linearApiRequestAllItems.call(this, 'data.issues', body);
} else {
const limit = this.getNodeParameter('limit', 0);
body.variables.first = limit;
responseData = await linearApiRequest.call(this, body);
responseData = responseData.data.issues.nodes;
responseData = await linearApiRequestAllItems.call(this, 'data.issues', body, limit);
}
}
if (operation === 'update') {