mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix flaky tests

Browse source
This commit is contained in:
Mutasem Aldmour 2024-11-14 13:45:20 +01:00
parent 289140bc6d
commit 47e80f70a6
No known key found for this signature in database
GPG key ID: 3DFA8122BB7FD6B8
5 changed files with 65 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

70
cypress/e2e/24-ndv-paired-item.cy.ts
View file

@ -31,29 +31,31 @@ describe('NDV', () => {
ndv.getters.inputTableRow(1).invoke('attr', 'data-test-id').should('equal', 'hovering-item'); ndv.getters.inputTableRow(1).invoke('attr', 'data-test-id').should('equal', 'hovering-item');
ndv.getters.inputTableRow(1).realHover(); ndv.actions.dragMainPanelToRight();
ndv.getters.inputTableRow(1).realMouseMove(10, 10);
ndv.getters.outputTableRow(4).invoke('attr', 'data-test-id').should('equal', 'hovering-item'); ndv.getters.outputTableRow(4).invoke('attr', 'data-test-id').should('equal', 'hovering-item');
ndv.getters.inputTableRow(2).realHover(); ndv.getters.inputTableRow(2).realMouseMove(10, 10);
ndv.getters.outputTableRow(2).invoke('attr', 'data-test-id').should('equal', 'hovering-item'); ndv.getters.outputTableRow(2).invoke('attr', 'data-test-id').should('equal', 'hovering-item');
ndv.getters.inputTableRow(3).realHover(); ndv.getters.inputTableRow(3).realMouseMove(10, 10);
ndv.getters.outputTableRow(6).invoke('attr', 'data-test-id').should('equal', 'hovering-item'); ndv.getters.outputTableRow(6).invoke('attr', 'data-test-id').should('equal', 'hovering-item');
// output to input // output to input
ndv.getters.outputTableRow(1).realHover(); ndv.actions.dragMainPanelToLeft();
ndv.getters.outputTableRow(1).realMouseMove(10, 10);
ndv.getters.inputTableRow(4).invoke('attr', 'data-test-id').should('equal', 'hovering-item'); ndv.getters.inputTableRow(4).invoke('attr', 'data-test-id').should('equal', 'hovering-item');
ndv.getters.outputTableRow(4).realHover(); ndv.getters.outputTableRow(4).realMouseMove(10, 10);
ndv.getters.inputTableRow(1).invoke('attr', 'data-test-id').should('equal', 'hovering-item'); ndv.getters.inputTableRow(1).invoke('attr', 'data-test-id').should('equal', 'hovering-item');
ndv.getters.outputTableRow(2).realHover(); ndv.getters.outputTableRow(2).realMouseMove(10, 10);
ndv.getters.inputTableRow(2).invoke('attr', 'data-test-id').should('equal', 'hovering-item'); ndv.getters.inputTableRow(2).invoke('attr', 'data-test-id').should('equal', 'hovering-item');
ndv.getters.outputTableRow(6).realHover(); ndv.getters.outputTableRow(6).realMouseMove(10, 10);
ndv.getters.inputTableRow(3).invoke('attr', 'data-test-id').should('equal', 'hovering-item'); ndv.getters.inputTableRow(3).invoke('attr', 'data-test-id').should('equal', 'hovering-item');
ndv.getters.outputTableRow(1).realHover(); ndv.getters.outputTableRow(1).realMouseMove(10, 10);
ndv.getters.inputTableRow(4).invoke('attr', 'data-test-id').should('equal', 'hovering-item'); ndv.getters.inputTableRow(4).invoke('attr', 'data-test-id').should('equal', 'hovering-item');
}); });
@ -75,31 +77,31 @@ describe('NDV', () => {
ndv.actions.switchInputMode('Table'); ndv.actions.switchInputMode('Table');
ndv.actions.switchOutputMode('Table'); ndv.actions.switchOutputMode('Table');
ndv.getters.backToCanvas().realHover(); // reset to default hover ndv.getters.backToCanvas().realMouseMove(10, 10); // reset to default hover
ndv.getters.outputHoveringItem().should('not.exist'); ndv.getters.outputHoveringItem().should('not.exist');
ndv.getters.parameterExpressionPreview('value').should('include.text', '1111'); ndv.getters.parameterExpressionPreview('value').should('include.text', '1111');
ndv.actions.selectInputNode('Set1'); ndv.actions.selectInputNode('Set1');
ndv.getters.backToCanvas().realHover(); // reset to default hover ndv.getters.backToCanvas().realMouseMove(10, 10); // reset to default hover
ndv.getters.inputTableRow(1).should('have.text', '1000'); ndv.getters.inputTableRow(1).should('have.text', '1000');
ndv.getters.inputTableRow(1).invoke('attr', 'data-test-id').should('equal', 'hovering-item'); ndv.getters.inputTableRow(1).invoke('attr', 'data-test-id').should('equal', 'hovering-item');
ndv.getters.inputTableRow(1).realHover(); ndv.actions.dragMainPanelToRight();
cy.wait(50); ndv.getters.inputTbodyCell(1, 0).realMouseMove(10, 10);
ndv.getters.outputHoveringItem().should('have.text', '1000'); ndv.getters.outputHoveringItem().should('have.text', '1000');
ndv.getters.parameterExpressionPreview('value').should('include.text', '1000'); ndv.getters.parameterExpressionPreview('value').should('include.text', '1000');
ndv.actions.selectInputNode('Sort'); ndv.actions.selectInputNode('Sort');
ndv.actions.dragMainPanelToLeft();
ndv.actions.changeOutputRunSelector('1 of 2 (6 items)'); ndv.actions.changeOutputRunSelector('1 of 2 (6 items)');
ndv.getters.backToCanvas().realHover(); // reset to default hover ndv.getters.backToCanvas().realMouseMove(10, 10); // reset to default hover
ndv.getters.inputTableRow(1).should('have.text', '1111'); ndv.getters.inputTableRow(1).should('have.text', '1111');
ndv.getters.inputTableRow(1).invoke('attr', 'data-test-id').should('equal', 'hovering-item'); ndv.getters.inputTableRow(1).invoke('attr', 'data-test-id').should('equal', 'hovering-item');
ndv.getters.inputTableRow(1).realHover(); ndv.getters.inputTbodyCell(1, 0).realMouseMove(10, 10);
cy.wait(50);
ndv.getters.outputHoveringItem().should('have.text', '1111'); ndv.getters.outputHoveringItem().should('have.text', '1111');
ndv.getters.parameterExpressionPreview('value').should('include.text', '1111'); ndv.getters.parameterExpressionPreview('value').should('include.text', '1111');
}); });
@ -132,20 +134,22 @@ describe('NDV', () => {
ndv.getters.inputTableRow(1).should('have.text', '1111'); ndv.getters.inputTableRow(1).should('have.text', '1111');
ndv.getters.inputTableRow(1).invoke('attr', 'data-test-id').should('equal', 'hovering-item'); ndv.getters.inputTableRow(1).invoke('attr', 'data-test-id').should('equal', 'hovering-item');
ndv.actions.dragMainPanelToLeft();
ndv.getters.outputTableRow(1).should('have.text', '1111'); ndv.getters.outputTableRow(1).should('have.text', '1111');
ndv.getters.outputTableRow(1).realHover(); ndv.getters.outputTableRow(1).realMouseMove(10, 10);
ndv.getters.outputTableRow(3).should('have.text', '4444'); ndv.getters.outputTableRow(3).should('have.text', '4444');
ndv.getters.outputTableRow(3).realHover(); ndv.getters.outputTableRow(3).realMouseMove(10, 10);
ndv.getters.inputTableRow(3).should('have.text', '4444'); ndv.getters.inputTableRow(3).should('have.text', '4444');
ndv.getters.inputTableRow(3).invoke('attr', 'data-test-id').should('equal', 'hovering-item'); ndv.getters.inputTableRow(3).invoke('attr', 'data-test-id').should('equal', 'hovering-item');
ndv.actions.changeOutputRunSelector('2 of 2 (6 items)'); ndv.actions.changeOutputRunSelector('2 of 2 (6 items)');
cy.wait(50);
ndv.getters.inputTableRow(1).should('have.text', '1000'); ndv.getters.inputTableRow(1).should('have.text', '1000');
ndv.getters.inputTableRow(1).realHover(); ndv.actions.dragMainPanelToRight();
ndv.getters.inputTableRow(1).realMouseMove(10, 10);
ndv.getters.outputTableRow(1).should('have.text', '1000'); ndv.getters.outputTableRow(1).should('have.text', '1000');
ndv.getters ndv.getters
@ -155,7 +159,8 @@ describe('NDV', () => {
.should('equal', 'hovering-item'); .should('equal', 'hovering-item');
ndv.getters.outputTableRow(3).should('have.text', '2000'); ndv.getters.outputTableRow(3).should('have.text', '2000');
ndv.getters.outputTableRow(3).realHover(); ndv.actions.dragMainPanelToLeft();
ndv.getters.outputTableRow(3).realMouseMove(10, 10);
ndv.getters.inputTableRow(3).should('have.text', '2000'); ndv.getters.inputTableRow(3).should('have.text', '2000');
@ -175,14 +180,15 @@ describe('NDV', () => {
ndv.actions.switchOutputBranch('False Branch (2 items)'); ndv.actions.switchOutputBranch('False Branch (2 items)');
ndv.getters.outputTableRow(1).should('have.text', '8888'); ndv.getters.outputTableRow(1).should('have.text', '8888');
ndv.getters.outputTableRow(1).realHover(); ndv.actions.dragMainPanelToLeft();
ndv.getters.outputTableRow(1).realMouseMove(10, 10);
ndv.getters.inputTableRow(5).should('have.text', '8888'); ndv.getters.inputTableRow(5).should('have.text', '8888');
ndv.getters.inputTableRow(5).invoke('attr', 'data-test-id').should('equal', 'hovering-item'); ndv.getters.inputTableRow(5).invoke('attr', 'data-test-id').should('equal', 'hovering-item');
ndv.getters.outputTableRow(2).should('have.text', '9999'); ndv.getters.outputTableRow(2).should('have.text', '9999');
ndv.getters.outputTableRow(2).realHover(); ndv.getters.outputTableRow(2).realMouseMove(10, 10);
ndv.getters.inputTableRow(6).should('have.text', '9999'); ndv.getters.inputTableRow(6).should('have.text', '9999');
@ -192,29 +198,35 @@ describe('NDV', () => {
workflowPage.actions.openNode('Set5'); workflowPage.actions.openNode('Set5');
ndv.actions.dragMainPanelToRight();
ndv.actions.switchInputBranch('True Branch'); ndv.actions.switchInputBranch('True Branch');
ndv.actions.dragMainPanelToLeft();
ndv.actions.changeOutputRunSelector('1 of 2 (2 items)'); ndv.actions.changeOutputRunSelector('1 of 2 (2 items)');
ndv.getters.outputTableRow(1).should('have.text', '8888'); ndv.getters.outputTableRow(1).should('have.text', '8888');
ndv.getters.outputTableRow(1).realHover(); ndv.getters.outputTableRow(1).realMouseMove(10, 10);
cy.wait(100);
ndv.getters.inputHoveringItem().should('not.exist'); ndv.getters.inputHoveringItem().should('not.exist');
ndv.getters.inputTableRow(1).should('have.text', '1111'); ndv.getters.inputTableRow(1).should('have.text', '1111');
ndv.getters.inputTableRow(1).realHover();
cy.wait(100); ndv.actions.dragMainPanelToRight();
ndv.getters.inputTableRow(1).realMouseMove(10, 10);
ndv.getters.outputHoveringItem().should('not.exist'); ndv.getters.outputHoveringItem().should('not.exist');
ndv.actions.switchInputBranch('False Branch'); ndv.actions.switchInputBranch('False Branch');
ndv.getters.inputTableRow(1).should('have.text', '8888'); ndv.getters.inputTableRow(1).should('have.text', '8888');
ndv.getters.inputTableRow(1).realHover(); ndv.actions.dragMainPanelToRight();
ndv.getters.inputTableRow(1).realMouseMove(10, 10);
ndv.actions.dragMainPanelToLeft();
ndv.actions.changeOutputRunSelector('2 of 2 (4 items)'); ndv.actions.changeOutputRunSelector('2 of 2 (4 items)');
ndv.getters.outputTableRow(1).should('have.text', '1111'); ndv.getters.outputTableRow(1).should('have.text', '1111');
ndv.getters.outputTableRow(1).realHover(); ndv.getters.outputTableRow(1).realMouseMove(10, 10);
ndv.actions.changeOutputRunSelector('1 of 2 (2 items)'); ndv.actions.changeOutputRunSelector('1 of 2 (2 items)');
ndv.getters.inputTableRow(1).should('have.text', '8888'); ndv.getters.inputTableRow(1).should('have.text', '8888');
ndv.getters.inputTableRow(1).realHover(); ndv.actions.dragMainPanelToRight();
ndv.getters.inputTableRow(1).realMouseMove(10, 10);
ndv.getters.outputHoveringItem().should('have.text', '8888'); ndv.getters.outputHoveringItem().should('have.text', '8888');
// todo there's a bug here need to fix ADO-534 // todo there's a bug here need to fix ADO-534
// ndv.getters.outputHoveringItem().should('not.exist'); // ndv.getters.outputHoveringItem().should('not.exist');

6
cypress/pages/ndv.ts
View file

@ -323,6 +323,12 @@ export class NDV extends BasePage {
addItemToFixedCollection: (paramName: string) => { addItemToFixedCollection: (paramName: string) => {
this.getters.fixedCollectionParameter(paramName).getByTestId('fixed-collection-add').click(); this.getters.fixedCollectionParameter(paramName).getByTestId('fixed-collection-add').click();
}, },
dragMainPanelToLeft: () => {
cy.drag('[data-test-id=panel-drag-button]', [-1000, 0], { moveTwice: true });
},
dragMainPanelToRight: () => {
cy.drag('[data-test-id=panel-drag-button]', [1000, 0], { moveTwice: true });
},
}; };
} }

10
cypress/support/commands.ts
View file

@ -177,6 +177,16 @@ Cypress.Commands.add('drag', (selector, pos, options) => {
pageY: newPosition.y, pageY: newPosition.y,
force: true, force: true,
}); });
if (options?.moveTwice) {
// first move like hover to trigger object to be visible
// like in main panel in ndv
element.trigger('mousemove', {
which: 1,
pageX: newPosition.x,
pageY: newPosition.y,
force: true,
});
}
if (options?.clickToFinish) { if (options?.clickToFinish) {
// Click to finish the drag // Click to finish the drag
// For some reason, mouseup isn't working when moving nodes // For some reason, mouseup isn't working when moving nodes

8
cypress/support/index.ts
View file

@ -59,7 +59,13 @@ declare global {
drag( drag(
selector: string | Chainable<JQuery<HTMLElement>>, selector: string | Chainable<JQuery<HTMLElement>>,
target: [number, number], target: [number, number],
options?: { abs?: boolean; index?: number; realMouse?: boolean; clickToFinish?: boolean }, options?: {
abs?: boolean;
index?: number;
realMouse?: boolean;
clickToFinish?: boolean;
moveTwice?: boolean;
},
): void; ): void;
draganddrop( draganddrop(
draggableSelector: string, draggableSelector: string,

2
packages/editor-ui/src/components/PanelDragButton.vue
View file

@ -35,7 +35,7 @@ const onDragStart = () => {
@dragend="onDragEnd" @dragend="onDragEnd"
> >
<template #default="{ isDragging }"> <template #default="{ isDragging }">
<div :class="{ [$style.dragButton]: true }"> <div :class="{ [$style.dragButton]: true }" data-test-id="panel-drag-button">
<span <span
v-if="canMoveLeft" v-if="canMoveLeft"
:class="{ [$style.leftArrow]: true, [$style.visible]: isDragging }" :class="{ [$style.leftArrow]: true, [$style.visible]: isDragging }"