mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-24 20:24:05 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

address comments

Browse source
This commit is contained in:
Mutasem 2021-07-09 11:01:46 +02:00
parent 436492c821
commit 480f969e07
3 changed files with 10 additions and 42 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
packages/editor-ui/src/Interface.ts
View file

@ -20,6 +20,11 @@ import {
WorkflowExecuteMode, WorkflowExecuteMode,
} from 'n8n-workflow'; } from 'n8n-workflow';
import {
IN8nUISettings,
IVersionNotificationSettings,
} from 'n8n';
import { import {
PaintStyle, PaintStyle,
} from 'jsplumb'; } from 'jsplumb';
@ -445,33 +450,6 @@ export interface IPushDataConsoleMessage {
message: string; message: string;
} }
export interface IVersionNotificationSettings {
enabled: boolean;
endpoint: string;
infoUrl: string;
}
export interface IN8nUISettings {
endpointWebhook: string;
endpointWebhookTest: string;
saveDataErrorExecution: string;
saveDataSuccessExecution: string;
saveManualExecutions: boolean;
timezone: string;
executionTimeout: number;
maxExecutionTimeout: number;
oauthCallbackUrls: {
oauth1: string;
oauth2: string;
};
urlBaseWebhook: string;
versionCli: string;
n8nMetadata?: {
[key: string]: string | number | undefined;
};
versionNotifications: IVersionNotificationSettings;
}
export interface IWorkflowSettings extends IWorkflowSettingsWorkflow { export interface IWorkflowSettings extends IWorkflowSettingsWorkflow {
errorWorkflow?: string; errorWorkflow?: string;
saveDataErrorExecution?: string; saveDataErrorExecution?: string;

5
packages/editor-ui/src/components/MainSidebar.vue
View file

@ -127,7 +127,7 @@
<MenuItemsIterator :items="sidebarMenuBottomItems" :root="true"/> <MenuItemsIterator :items="sidebarMenuBottomItems" :root="true"/>
<div class="foot-menu-items"> <div class="footer-menu-items">
<el-menu-item index="updates" class="updates" v-if="hasVersionUpdates" @click="openUpdatesPanel"> <el-menu-item index="updates" class="updates" v-if="hasVersionUpdates" @click="openUpdatesPanel">
<div class="gift-container"> <div class="gift-container">
<div class="gift-icon"> <div class="gift-icon">
@ -597,11 +597,12 @@ a.logo {
} }
} }
.foot-menu-items { .footer-menu-items {
display: flex; display: flex;
flex-grow: 1; flex-grow: 1;
flex-direction: column; flex-direction: column;
justify-content: flex-end; justify-content: flex-end;
padding-bottom: 32px;
} }
.el-menu-item.updates { .el-menu-item.updates {

15
packages/editor-ui/src/components/VersionCard.vue
View file

@ -27,7 +27,7 @@
</div> </div>
<div> <div>
<div v-html="version.description" :class="$style.description"></div> <div v-html="version.description" :class="$style.description"></div>
<div :class="`${$style.nodes} ${hasMoreThan2Rows ? $style.expanded: ''}`" v-if="version.nodes && version.nodes.length > 0"> <div :class="$style.nodes" v-if="version.nodes && version.nodes.length > 0">
<NodeIcon <NodeIcon
v-for="node in version.nodes" v-for="node in version.nodes"
:key="node.name" :key="node.name"
@ -41,7 +41,6 @@
<script lang="ts"> <script lang="ts">
import Vue from 'vue'; import Vue from 'vue';
import NodeIcon from './NodeIcon.vue'; import NodeIcon from './NodeIcon.vue';
import { IVersion } from '@/Interface';
import TimeAgo from './TimeAgo.vue'; import TimeAgo from './TimeAgo.vue';
import Badge from './Badge.vue'; import Badge from './Badge.vue';
import WarningTooltip from './WarningTooltip.vue'; import WarningTooltip from './WarningTooltip.vue';
@ -51,12 +50,6 @@ export default Vue.extend({
components: { NodeIcon, TimeAgo, Badge, WarningTooltip }, components: { NodeIcon, TimeAgo, Badge, WarningTooltip },
name: 'UpdatesPanel', name: 'UpdatesPanel',
props: ['version'], props: ['version'],
computed: {
hasMoreThan2Rows(): boolean {
const version = this.version as IVersion;
return version.nodes && version.nodes.length > 20;
},
},
}); });
</script> </script>
@ -119,11 +112,7 @@ export default Vue.extend({
.nodes { .nodes {
display: grid; display: grid;
grid-template-columns: repeat(10, 1fr); grid-template-columns: repeat(10, 1fr);
grid-row-gap: 5px; grid-row-gap: 12px;
margin-block-start: 24px; margin-block-start: 24px;
} }
.expanded {
grid-row-gap: 8px;
}
</style> </style>