mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: Chat Trigger exclude summarization node from valid ai nodes (#8875)

Browse source
This commit is contained in:
Michael Kret 2024-03-14 09:43:56 +02:00 committed by GitHub
parent 5201484d7a
commit 4861556a1c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/editor-ui/src/components/WorkflowLMChat.vue
View file

@ -128,6 +128,7 @@ import {
AI_CATEGORY_CHAINS, AI_CATEGORY_CHAINS,
AI_CODE_NODE_TYPE, AI_CODE_NODE_TYPE,
AI_SUBCATEGORY, AI_SUBCATEGORY,
CHAIN_SUMMARIZATION_LANGCHAIN_NODE_TYPE,
CHAT_EMBED_MODAL_KEY, CHAT_EMBED_MODAL_KEY,
CHAT_TRIGGER_NODE_TYPE, CHAT_TRIGGER_NODE_TYPE,
MANUAL_CHAT_TRIGGER_NODE_TYPE, MANUAL_CHAT_TRIGGER_NODE_TYPE,
@ -297,6 +298,7 @@ export default defineComponent({
const workflow = this.workflowHelpers.getCurrentWorkflow(); const workflow = this.workflowHelpers.getCurrentWorkflow();
const chatNode = this.workflowsStore.getNodes().find((node: INodeUi): boolean => { const chatNode = this.workflowsStore.getNodes().find((node: INodeUi): boolean => {
if (node.type === CHAIN_SUMMARIZATION_LANGCHAIN_NODE_TYPE) return false;
const nodeType = this.nodeTypesStore.getNodeType(node.type, node.typeVersion); const nodeType = this.nodeTypesStore.getNodeType(node.type, node.typeVersion);
if (!nodeType) return false; if (!nodeType) return false;
@ -335,7 +337,7 @@ export default defineComponent({
if (!chatNode) { if (!chatNode) {
this.showError( this.showError(
new Error( new Error(
'Chat only works when an AI agent or chain is connected to the chat trigger node', 'Chat only works when an AI agent or chain(except summarization chain) is connected to the chat trigger node',
), ),
'Missing AI node', 'Missing AI node',
); );

4
packages/editor-ui/src/components/__tests__/WorkflowLMChatModal.test.ts
View file

@ -105,7 +105,7 @@ describe('WorkflowLMChatModal', () => {
await waitFor(() => await waitFor(() =>
expect(document.querySelectorAll('.el-notification')[0]).toHaveTextContent( expect(document.querySelectorAll('.el-notification')[0]).toHaveTextContent(
'Missing AI node Chat only works when an AI agent or chain is connected to the chat trigger node', 'Missing AI node Chat only works when an AI agent or chain(except summarization chain) is connected to the chat trigger node',
), ),
); );
}); });
@ -120,7 +120,7 @@ describe('WorkflowLMChatModal', () => {
await waitFor(() => await waitFor(() =>
expect(document.querySelectorAll('.el-notification')[1]).toHaveTextContent( expect(document.querySelectorAll('.el-notification')[1]).toHaveTextContent(
'Missing AI node Chat only works when an AI agent or chain is connected to the chat trigger node', 'Missing AI node Chat only works when an AI agent or chain(except summarization chain) is connected to the chat trigger node',
), ),
); );
}); });

2
packages/editor-ui/src/constants.ts
View file

@ -181,6 +181,8 @@ export const CRYPTO_NODE_TYPE = 'n8n-nodes-base.crypto';
export const RSS_READ_NODE_TYPE = 'n8n-nodes-base.rssFeedRead'; export const RSS_READ_NODE_TYPE = 'n8n-nodes-base.rssFeedRead';
export const COMPRESSION_NODE_TYPE = 'n8n-nodes-base.compression'; export const COMPRESSION_NODE_TYPE = 'n8n-nodes-base.compression';
export const EDIT_IMAGE_NODE_TYPE = 'n8n-nodes-base.editImage'; export const EDIT_IMAGE_NODE_TYPE = 'n8n-nodes-base.editImage';
export const CHAIN_SUMMARIZATION_LANGCHAIN_NODE_TYPE =
'@n8n/n8n-nodes-langchain.chainSummarization';
export const CREDENTIAL_ONLY_NODE_PREFIX = 'n8n-creds-base'; export const CREDENTIAL_ONLY_NODE_PREFIX = 'n8n-creds-base';
export const CREDENTIAL_ONLY_HTTP_NODE_VERSION = 4.1; export const CREDENTIAL_ONLY_HTTP_NODE_VERSION = 4.1;