mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-11 21:07:28 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(Google Drive Node): Fix issue preventing upload / update working in some configurations (#8417)

Browse source
This commit is contained in:
Jon 2024-01-23 16:30:15 +00:00 committed by GitHub
parent a8b4684192
commit 4b3ea81028
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 11 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/nodes-base/nodes/Google/Drive/test/v2/node/file/copy.test.ts
View file

@ -26,7 +26,7 @@ describe('test GoogleDriveV2: file copy', () => {
jest.unmock('../../../../v2/transport'); jest.unmock('../../../../v2/transport');
}); });
it('shuold be called with', async () => { it('should be called with', async () => {
const nodeParameters = { const nodeParameters = {
operation: 'copy', operation: 'copy',
fileId: { fileId: {

2
packages/nodes-base/nodes/Google/Drive/test/v2/node/file/createFromText.test.ts
View file

@ -26,7 +26,7 @@ describe('test GoogleDriveV2: file createFromText', () => {
jest.unmock('../../../../v2/transport'); jest.unmock('../../../../v2/transport');
}); });
it('shuold be called with', async () => { it('should be called with', async () => {
const nodeParameters = { const nodeParameters = {
operation: 'createFromText', operation: 'createFromText',
content: 'hello drive!', content: 'hello drive!',

2
packages/nodes-base/nodes/Google/Drive/test/v2/node/file/deleteFile.test.ts
View file

@ -26,7 +26,7 @@ describe('test GoogleDriveV2: file deleteFile', () => {
jest.unmock('../../../../v2/transport'); jest.unmock('../../../../v2/transport');
}); });
it('shuold be called with', async () => { it('should be called with', async () => {
const nodeParameters = { const nodeParameters = {
operation: 'deleteFile', operation: 'deleteFile',
fileId: { fileId: {

2
packages/nodes-base/nodes/Google/Drive/test/v2/node/file/move.test.ts
View file

@ -31,7 +31,7 @@ describe('test GoogleDriveV2: file move', () => {
jest.unmock('../../../../v2/transport'); jest.unmock('../../../../v2/transport');
}); });
it('shuold be called with', async () => { it('should be called with', async () => {
const nodeParameters = { const nodeParameters = {
operation: 'move', operation: 'move',
fileId: { fileId: {

2
packages/nodes-base/nodes/Google/Drive/test/v2/node/file/share.test.ts
View file

@ -26,7 +26,7 @@ describe('test GoogleDriveV2: file share', () => {
jest.unmock('../../../../v2/transport'); jest.unmock('../../../../v2/transport');
}); });
it('shuold be called with', async () => { it('should be called with', async () => {
const nodeParameters = { const nodeParameters = {
operation: 'share', operation: 'share',
fileId: { fileId: {

2
packages/nodes-base/nodes/Google/Drive/test/v2/node/file/update.test.ts
View file

@ -26,7 +26,7 @@ describe('test GoogleDriveV2: file update', () => {
jest.unmock('../../../../v2/transport'); jest.unmock('../../../../v2/transport');
}); });
it('shuold be called with', async () => { it('should be called with', async () => {
const nodeParameters = { const nodeParameters = {
operation: 'update', operation: 'update',
fileId: { fileId: {

4
packages/nodes-base/nodes/Google/Drive/test/v2/node/file/upload.test.ts
View file

@ -48,7 +48,7 @@ describe('test GoogleDriveV2: file upload', () => {
jest.unmock('../../../../v2/helpers/utils'); jest.unmock('../../../../v2/helpers/utils');
}); });
it('shuold be called with', async () => { it('should be called with', async () => {
const nodeParameters = { const nodeParameters = {
name: 'newFile.txt', name: 'newFile.txt',
folderId: { folderId: {
@ -75,7 +75,7 @@ describe('test GoogleDriveV2: file upload', () => {
undefined, undefined,
{ uploadType: 'resumable' }, { uploadType: 'resumable' },
undefined, undefined,
{ resolveWithFullResponse: true }, { returnFullResponse: true },
); );
expect(transport.googleApiRequest).toHaveBeenCalledWith( expect(transport.googleApiRequest).toHaveBeenCalledWith(
'PATCH', 'PATCH',

2
packages/nodes-base/nodes/Google/Drive/v2/actions/file/update.operation.ts
View file

@ -203,7 +203,7 @@ export async function execute(this: IExecuteFunctions, i: number): Promise<INode
{ uploadType: 'resumable' }, { uploadType: 'resumable' },
undefined, undefined,
{ {
resolveWithFullResponse: true, returnFullResponse: true,
}, },
); );
const uploadUrl = resumableUpload.headers.location; const uploadUrl = resumableUpload.headers.location;

3
packages/nodes-base/nodes/Google/Drive/v2/actions/file/upload.operation.ts
View file

@ -123,9 +123,10 @@ export async function execute(this: IExecuteFunctions, i: number): Promise<INode
{ uploadType: 'resumable' }, { uploadType: 'resumable' },
undefined, undefined,
{ {
resolveWithFullResponse: true, returnFullResponse: true,
}, },
); );
const uploadUrl = resumableUpload.headers.location; const uploadUrl = resumableUpload.headers.location;
let offset = 0; let offset = 0;