From 4cb4c5e8188fd930312e3bf720472af35731a968 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E0=A4=95=E0=A4=BE=E0=A4=B0=E0=A4=A4=E0=A5=8B=E0=A4=AB?= =?UTF-8?q?=E0=A5=8D=E0=A4=AB=E0=A5=87=E0=A4=B2=E0=A4=B8=E0=A5=8D=E0=A4=95?= =?UTF-8?q?=E0=A5=8D=E0=A4=B0=E0=A4=BF=E0=A4=AA=E0=A5=8D=E0=A4=9F=E2=84=A2?= Date: Thu, 8 Dec 2022 13:32:33 +0100 Subject: [PATCH] fix: Stop returning `UNKNOWN ERROR` in the response if an actual error message is available (#4859) --- packages/cli/src/ResponseHelper.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/cli/src/ResponseHelper.ts b/packages/cli/src/ResponseHelper.ts index 8ade1c3f16..9117b2bac2 100644 --- a/packages/cli/src/ResponseHelper.ts +++ b/packages/cli/src/ResponseHelper.ts @@ -133,7 +133,7 @@ export function sendErrorResponse(res: Response, error: Error) { const response: ErrorResponse = { code: 0, - message: 'Unknown error', + message: error.message ?? 'Unknown error', }; if (error instanceof ResponseError) { @@ -141,7 +141,6 @@ export function sendErrorResponse(res: Response, error: Error) { console.error(picocolors.red(error.httpStatusCode), error.message); } - response.message = error.message; httpStatusCode = error.httpStatusCode; if (error.errorCode) {