mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(editor): Fix execution running status listener for chat messages (#12951)

Browse source
This commit is contained in:
Alex Grozav 2025-01-31 09:49:38 +02:00 committed by GitHub
parent 7031569a02
commit 4d55a29460
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 15 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
packages/editor-ui/src/components/CanvasChat/CanvasChat.test.ts
View file

@ -215,6 +215,7 @@ describe('CanvasChat', () => {
// Send message
const input = await findByTestId('chat-input');
await userEvent.type(input, 'Hello AI!');
await userEvent.keyboard('{Enter}');
// Verify message and response
@ -263,14 +264,18 @@ describe('CanvasChat', () => {
// Send message
const input = await findByTestId('chat-input');
await userEvent.type(input, 'Test message');
workflowsStore.isWorkflowRunning = true;
await userEvent.keyboard('{Enter}');
await waitFor(() => expect(queryByTestId('chat-message-typing')).toBeInTheDocument());
workflowsStore.isWorkflowRunning = false;
workflowsStore.getWorkflowExecution = {
...(mockWorkflowExecution as unknown as IExecutionResponse),
status: 'success',
};
await waitFor(() => expect(queryByTestId('chat-message-typing')).not.toBeInTheDocument());
});

30
packages/editor-ui/src/components/CanvasChat/CanvasChat.vue
View file

@ -175,28 +175,18 @@ const closePanel = () => {
// This function creates a promise that resolves when the workflow execution completes
// It's used to handle the loading state while waiting for the workflow to finish
async function createExecutionPromise() {
let resolvePromise: () => void;
const promise = new Promise<void>((resolve) => {
resolvePromise = resolve;
});
// Watch for changes in the workflow execution status
const stopWatch = watch(
() => workflowsStore.getWorkflowExecution?.status,
(newStatus) => {
// If the status is no longer 'running', resolve the promise
if (newStatus && newStatus !== 'running') {
resolvePromise();
// Stop the watcher when the promise is resolved
stopWatch();
return await new Promise<void>((resolve) => {
const resolveIfFinished = (isRunning: boolean) => {
if (!isRunning) {
unwatch();
resolve();
}
},
{ immediate: true }, // Check the status immediately when the watcher is set up
);
};
// Return the promise, which will resolve when the workflow execution is complete
// This allows the caller to await the execution and handle the loading state appropriately
return await promise;
// Watch for changes in the workflow execution status
const unwatch = watch(() => workflowsStore.isWorkflowRunning, resolveIfFinished);
resolveIfFinished(workflowsStore.isWorkflowRunning);
});
}
async function onRunChatWorkflow(payload: RunWorkflowChatPayload) {