mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(editor): Fix displaying of some trigger nodes in the creator panel (#5040)

Browse source
This commit is contained in:
OlegIvaniv 2022-12-28 09:21:22 +01:00 committed by GitHub
parent 18140e059b
commit 4daf905ce2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
packages/editor-ui/src/stores/nodeCreator.ts
View file

@ -306,8 +306,16 @@ export const useNodeCreatorStore = defineStore(STORES.NODE_CREATOR, {
return nodesWithActions; return nodesWithActions;
}, },
mergedAppNodes(): INodeTypeDescription[] { mergedAppNodes(): INodeTypeDescription[] {
const mergedNodes = this.visibleNodesWithActions.reduce( const mergedNodes = [...this.visibleNodesWithActions]
(acc: Record<string, INodeTypeDescription>, node: INodeTypeDescription) => { // Sort triggers so they are always on top and when later get merged
// they won't be discarded if they have the same name as a core node which doesn't contain actions
.sort((a, b) => {
if (a.group.includes('trigger')) return -1;
if (b.group.includes('trigger')) return 1;
return 0;
})
.reduce((acc: Record<string, INodeTypeDescription>, node: INodeTypeDescription) => {
const clonedNode = deepCopy(node); const clonedNode = deepCopy(node);
const isCoreNode = node.codex?.categories?.includes(CORE_NODES_CATEGORY); const isCoreNode = node.codex?.categories?.includes(CORE_NODES_CATEGORY);
const actions = node.actions || []; const actions = node.actions || [];
@ -324,14 +332,15 @@ export const useNodeCreatorStore = defineStore(STORES.NODE_CREATOR, {
acc[normalizedName].displayName = node.displayName.replace('Trigger', ''); acc[normalizedName].displayName = node.displayName.replace('Trigger', '');
} }
acc[normalizedName].actions = filterSinglePlaceholderAction(
acc[normalizedName].actions || [],
);
return acc; return acc;
}, }, {});
{},
); const filteredNodes = Object.values(mergedNodes).map((node) => ({
return Object.values(mergedNodes); ...node,
actions: filterSinglePlaceholderAction(node.actions || []),
}));
return filteredNodes;
}, },
getNodeTypesWithManualTrigger: getNodeTypesWithManualTrigger:
() => () =>