mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 12:44:07 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(core): Fix the issue with test webhooks getting removed incorrectly (no-changelog) (#5466)

Browse source 
This broke because of the change [here](https://github.com/n8n-io/n8n/pull/5443/files#diff-b386248ff00977749c873ed85821c241b773e9740d7e7adf94e05b73b350ed74L152).
`finally` block is called even if there is a `return` in the `try` block, and this is causing the test webhook to be removed, even when it shouldn't be removed.
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™ 2023-02-13 16:16:53 +01:00 committed by GitHub
parent e705701cb0
commit 4dc458eca5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
packages/cli/src/TestWebhooks.ts
View file

@ -141,13 +141,13 @@ class TestWebhooks {
if (sessionId !== undefined) {
push.send('testWebhookReceived', { workflowId, executionId }, sessionId);
}
} finally {
// Delete webhook also if an error is thrown
if (timeout) clearTimeout(timeout);
delete testWebhookData[webhookKey];
} catch {}
await activeWebhooks.removeWorkflow(workflow);
}
// Delete webhook also if an error is thrown
if (timeout) clearTimeout(timeout);
delete testWebhookData[webhookKey];
await activeWebhooks.removeWorkflow(workflow);
});
}