diff --git a/.eslintrc.json b/.eslintrc.json deleted file mode 100644 index cce72ec974..0000000000 --- a/.eslintrc.json +++ /dev/null @@ -1,50 +0,0 @@ -{ - "env": { - "browser": true, - "es6": true - }, - "extends": [ - "eslint:recommended", - "plugin:vue/essential", - "tslint-eslint-rules" - ], - "globals": { - "Atomics": "readonly", - "SharedArrayBuffer": "readonly" - }, - "parserOptions": { - "ecmaVersion": 2018, - "parser": "@typescript-eslint/parser", - "sourceType": "module" - }, - "plugins": [ - "vue", - "@typescript-eslint" - ], - "parser": "@typescript-eslint/parser", - "rules": { - "indent": [ - "error", - "tab" - ], - "linebreak-style": [ - "error", - "unix" - ], - "quotes": [ - "error", - "single" - ], - "semi": [ - "error", - "always" - ], - "sort-imports": ["error", { - "ignoreCase": false, - "ignoreMemberSort": false, - "memberSyntaxSortOrder": ["none", "all", "multiple", "single"] - }], - "no-unused-vars": "off", - "@typescript-eslint/no-unused-vars": ["error"] - } -} \ No newline at end of file diff --git a/package.json b/package.json index 0fd1747984..3b96e2de5d 100644 --- a/package.json +++ b/package.json @@ -19,6 +19,7 @@ "postcss": {}, "dependencies": { "@typescript-eslint/parser": "^2.31.0", - "tslint-eslint-rules": "^5.4.0" + "tslint-eslint-rules": "^5.4.0", + "typescript-tslint-plugin": "^0.5.5" } } diff --git a/packages/nodes-base/nodes/AgileCrm/CompanyDescription.ts b/packages/nodes-base/nodes/AgileCrm/CompanyDescription.ts index 8dd417bfe1..08a7fa1df9 100644 --- a/packages/nodes-base/nodes/AgileCrm/CompanyDescription.ts +++ b/packages/nodes-base/nodes/AgileCrm/CompanyDescription.ts @@ -1,7 +1,6 @@ import { INodeProperties, } from 'n8n-workflow'; - export const companyOperations = [ { displayName: 'Operation', @@ -45,7 +44,6 @@ export const companyOperations = [ description: 'The operation to perform.', }, ] as INodeProperties[]; - export const companyFields = [ /* -------------------------------------------------------------------------- */ /* company:get */ @@ -69,7 +67,6 @@ export const companyFields = [ description: 'Unique identifier for a particular company', }, - /* -------------------------------------------------------------------------- */ /* company:get all */ /* -------------------------------------------------------------------------- */ @@ -109,11 +106,9 @@ export const companyFields = [ }, } }, - /* -------------------------------------------------------------------------- */ /* company:create */ /* -------------------------------------------------------------------------- */ - { displayName: 'JSON Parameters', name: 'jsonParameters', @@ -155,7 +150,6 @@ export const companyFields = [ description: 'Object of values to set as described here.', }, - { displayName: 'Additional Fields', name: 'additionalFields', @@ -181,7 +175,6 @@ export const companyFields = [ name: 'starValue', type: 'options', default: '', - description: 'Rating of company (Max value 5). This is not applicable for companies.', options: [ { @@ -216,7 +209,6 @@ export const companyFields = [ type: 'number', default: '', description: 'Score of company. This is not applicable for companies.', - typeOptions: { minValue: 0 } @@ -237,7 +229,6 @@ export const companyFields = [ displayName: 'Name', name: 'name', type: 'string', - default: '', placeholder: 'Company name', description: 'Company name.', @@ -483,7 +474,6 @@ export const companyFields = [ description: 'Object of values to set as described here.', }, - { displayName: 'Additional Fields', name: 'additionalFields', @@ -509,7 +499,6 @@ export const companyFields = [ name: 'starValue', type: 'options', default: '', - description: 'Rating of company (Max value 5). This is not applicable for companies.', options: [ { @@ -544,7 +533,6 @@ export const companyFields = [ type: 'number', default: '', description: 'Score of company. This is not applicable for companies.', - typeOptions: { minValue: 0 } @@ -565,7 +553,6 @@ export const companyFields = [ displayName: 'Name', name: 'name', type: 'string', - default: '', placeholder: 'Company name', description: 'Company name.', @@ -574,7 +561,6 @@ export const companyFields = [ displayName: 'Email', name: 'email', type: 'string', - default: '', placeholder: 'Company email', description: 'Company email.', @@ -583,7 +569,6 @@ export const companyFields = [ displayName: 'Address', name: 'email', type: 'string', - default: '', placeholder: 'Company address', description: 'Company address.', @@ -592,7 +577,6 @@ export const companyFields = [ displayName: 'Website', name: 'websiteOptions', type: 'fixedCollection', - description: 'companys websites.', typeOptions: { multipleValues: true, @@ -608,7 +592,6 @@ export const companyFields = [ type: 'options', required: true, default: '', - description: 'Type of website.', options: [ { @@ -663,7 +646,6 @@ export const companyFields = [ type: 'string', required: true, default: '', - description: 'Website URL', } ] @@ -675,7 +657,6 @@ export const companyFields = [ displayName: 'Phone', name: 'phone', type: 'string', - default: '', placeholder: 'Company phone', description: 'Company phone.', @@ -684,7 +665,6 @@ export const companyFields = [ displayName: 'Custom Properties', name: 'customProperties', type: 'fixedCollection', - description: 'Custom Properties', typeOptions: { multipleValues: true, @@ -700,25 +680,20 @@ export const companyFields = [ type: 'string', required: true, default: '', - description: 'Property name.' }, { displayName: 'Sub Type', name: 'subtype', type: 'string', - default: '', - description: 'Property sub type.', }, { displayName: 'Value', name: 'value', type: 'string', - default: '', - description: 'Property value.', } ] @@ -728,5 +703,4 @@ export const companyFields = [ }, ], }, - ] as INodeProperties[]; diff --git a/packages/nodes-base/nodes/AgileCrm/ContactDescription.ts b/packages/nodes-base/nodes/AgileCrm/ContactDescription.ts index fe4a811b88..fd7d652867 100644 --- a/packages/nodes-base/nodes/AgileCrm/ContactDescription.ts +++ b/packages/nodes-base/nodes/AgileCrm/ContactDescription.ts @@ -282,7 +282,6 @@ export const contactFields = [ type: 'options', required: true, default: "", - description: 'Type of Email', options: [ { @@ -301,7 +300,6 @@ export const contactFields = [ type: 'string', required: true, default: "", - description: 'Email', } ] @@ -352,7 +350,6 @@ export const contactFields = [ type: 'string', required: true, default: "", - description: 'Full address.', } ] @@ -379,7 +376,6 @@ export const contactFields = [ type: 'options', required: true, default: "", - description: 'Type of website.', options: [ { @@ -434,7 +430,6 @@ export const contactFields = [ type: 'string', required: true, default: "", - description: 'Website URL', } ] @@ -461,7 +456,6 @@ export const contactFields = [ type: 'options', required: true, default: "", - description: 'Type of phone number.', options: [ { @@ -501,7 +495,6 @@ export const contactFields = [ type: 'string', required: true, default: "", - description: 'Phone number.', } ] @@ -528,7 +521,6 @@ export const contactFields = [ type: 'string', required: true, default: "", - description: 'Property name.' }, { @@ -536,7 +528,6 @@ export const contactFields = [ name: 'subtype', type: 'string', default: "", - description: 'Property sub type.', }, { @@ -544,7 +535,6 @@ export const contactFields = [ name: 'value', type: 'string', default: "", - description: 'Property value.', } ] @@ -782,7 +772,6 @@ export const contactFields = [ type: 'string', required: true, default: "", - description: 'Email', } ] @@ -833,7 +822,6 @@ export const contactFields = [ type: 'string', required: true, default: "", - description: 'Full address.', } ] @@ -915,7 +903,6 @@ export const contactFields = [ type: 'string', required: true, default: "", - description: 'Website URL', } ] @@ -942,7 +929,6 @@ export const contactFields = [ type: 'options', required: true, default: "", - description: 'Type of phone number.', options: [ { @@ -982,7 +968,6 @@ export const contactFields = [ type: 'string', required: true, default: "", - description: 'Phone number.', } ] @@ -1009,7 +994,6 @@ export const contactFields = [ type: 'string', required: true, default: "", - description: 'Property name.' }, { @@ -1017,7 +1001,6 @@ export const contactFields = [ name: 'subtype', type: 'string', default: "", - description: 'Property sub type.', }, { @@ -1025,7 +1008,6 @@ export const contactFields = [ name: 'value', type: 'string', default: "", - description: 'Property value.', } ] diff --git a/packages/nodes-base/nodes/AgileCrm/DealDescription.ts b/packages/nodes-base/nodes/AgileCrm/DealDescription.ts index f95cb02f05..2ee7e9d1a2 100644 --- a/packages/nodes-base/nodes/AgileCrm/DealDescription.ts +++ b/packages/nodes-base/nodes/AgileCrm/DealDescription.ts @@ -319,16 +319,13 @@ export const dealFields = [ type: 'string', required: true, default: "", - description: 'Property name.' }, { displayName: 'Value', name: 'value', type: 'string', - default: "", - description: 'Property value.', } ] @@ -448,7 +445,6 @@ export const dealFields = [ displayName: 'Expected Value', name: 'expectedValue', type: 'number', - typeOptions: { minValue: 0, maxValue: 10000 @@ -460,7 +456,6 @@ export const dealFields = [ displayName: 'Probability', name: 'probability', type: 'number', - typeOptions: { minValue: 0, maxValue: 100 @@ -472,7 +467,6 @@ export const dealFields = [ displayName: 'Name', name: 'name', type: 'string', - default: '', description: 'Name of deal.', }, @@ -492,7 +486,6 @@ export const dealFields = [ displayName: 'Custom Data', name: 'customData', type: 'fixedCollection', - description: 'Custom Data', typeOptions: { multipleValues: true, @@ -508,16 +501,13 @@ export const dealFields = [ type: 'string', required: true, default: "", - description: 'Property name.' }, { displayName: 'Value', name: 'value', type: 'string', - default: "", - description: 'Property value.', } ] diff --git a/packages/nodes-base/nodes/AgileCrm/GenericFunctions.ts b/packages/nodes-base/nodes/AgileCrm/GenericFunctions.ts index a48c4e6860..9a762044cd 100644 --- a/packages/nodes-base/nodes/AgileCrm/GenericFunctions.ts +++ b/packages/nodes-base/nodes/AgileCrm/GenericFunctions.ts @@ -73,7 +73,7 @@ export async function agileCrmApiRequestUpdate(this: IHookFunctions | IExecuteFu const payload : IContactUpdate = body; try { - // Due to API, we must update each property separately + // Due to API, we must update each property separately. For user it looks like one seamless update if(payload.properties){ options.body.properties = payload.properties; options.uri = baseUri + 'api/contacts/edit-properties';