mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-12 15:44:06 -08:00
fix: Show actual execution data for production executions even if pin data exists (#6302)
This commit is contained in:
parent
b5cabfef54
commit
4eb8437196
|
@ -27,6 +27,7 @@ import { useToast } from '@/composables';
|
|||
import type { IWorkflowDb } from '@/Interface';
|
||||
import { mapStores } from 'pinia';
|
||||
import { useRootStore } from '@/stores/n8nRoot.store';
|
||||
import { useWorkflowsStore } from '@/stores';
|
||||
|
||||
export default defineComponent({
|
||||
name: 'WorkflowPreview',
|
||||
|
@ -73,7 +74,7 @@ export default defineComponent({
|
|||
};
|
||||
},
|
||||
computed: {
|
||||
...mapStores(useRootStore),
|
||||
...mapStores(useRootStore, useWorkflowsStore),
|
||||
showPreview(): boolean {
|
||||
return (
|
||||
!this.loading &&
|
||||
|
@ -134,6 +135,16 @@ export default defineComponent({
|
|||
}),
|
||||
'*',
|
||||
);
|
||||
|
||||
if (this.workflowsStore.activeWorkflowExecution) {
|
||||
iframeRef.contentWindow.postMessage(
|
||||
JSON.stringify({
|
||||
command: 'setActiveExecution',
|
||||
execution: this.workflowsStore.activeWorkflowExecution,
|
||||
}),
|
||||
'*',
|
||||
);
|
||||
}
|
||||
}
|
||||
} catch (error) {
|
||||
this.showError(
|
||||
|
|
|
@ -223,8 +223,11 @@ function connectionInputData(
|
|||
}
|
||||
}
|
||||
|
||||
const parentPinData = parentNode.reduce((acc: INodeExecutionData[], parentNodeName, index) => {
|
||||
const pinData = useWorkflowsStore().pinDataByNodeName(parentNodeName);
|
||||
const workflowsStore = useWorkflowsStore();
|
||||
|
||||
if (workflowsStore.shouldReplaceInputDataWithPinData) {
|
||||
const parentPinData = parentNode.reduce<INodeExecutionData[]>((acc, parentNodeName, index) => {
|
||||
const pinData = workflowsStore.pinDataByNodeName(parentNodeName);
|
||||
|
||||
if (pinData) {
|
||||
acc.push({
|
||||
|
@ -251,6 +254,7 @@ function connectionInputData(
|
|||
connectionInputData = parentPinData;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return connectionInputData;
|
||||
}
|
||||
|
@ -271,8 +275,10 @@ function executeData(
|
|||
// Add the input data to be able to also resolve the short expression format
|
||||
// which does not use the node name
|
||||
const parentNodeName = parentNode[0];
|
||||
const workflowsStore = useWorkflowsStore();
|
||||
|
||||
const parentPinData = useWorkflowsStore().getPinData![parentNodeName];
|
||||
if (workflowsStore.shouldReplaceInputDataWithPinData) {
|
||||
const parentPinData = workflowsStore.getPinData![parentNodeName];
|
||||
|
||||
// populate `executeData` from `pinData`
|
||||
|
||||
|
@ -282,10 +288,11 @@ function executeData(
|
|||
|
||||
return executeData;
|
||||
}
|
||||
}
|
||||
|
||||
// populate `executeData` from `runData`
|
||||
|
||||
const workflowRunData = useWorkflowsStore().getWorkflowRunData;
|
||||
const workflowRunData = workflowsStore.getWorkflowRunData;
|
||||
if (workflowRunData === null) {
|
||||
return executeData;
|
||||
}
|
||||
|
|
31
packages/editor-ui/src/stores/__tests__/workflows.test.ts
Normal file
31
packages/editor-ui/src/stores/__tests__/workflows.test.ts
Normal file
|
@ -0,0 +1,31 @@
|
|||
import { createTestingPinia } from '@pinia/testing';
|
||||
import { useWorkflowsStore } from '@/stores';
|
||||
|
||||
let pinia: ReturnType<typeof createTestingPinia>;
|
||||
beforeAll(() => {
|
||||
pinia = createTestingPinia();
|
||||
});
|
||||
|
||||
describe('Workflows Store', () => {
|
||||
describe('shouldReplaceInputDataWithPinData', () => {
|
||||
beforeEach(() => {
|
||||
pinia.state.value = {
|
||||
workflows: useWorkflowsStore(),
|
||||
};
|
||||
});
|
||||
|
||||
it('should return true if no active execution is set', () => {
|
||||
expect(useWorkflowsStore().shouldReplaceInputDataWithPinData).toBe(true);
|
||||
});
|
||||
|
||||
it('should return true if active execution is set and mode is manual', () => {
|
||||
pinia.state.value.workflows.activeWorkflowExecution = { mode: 'manual' };
|
||||
expect(useWorkflowsStore().shouldReplaceInputDataWithPinData).toBe(true);
|
||||
});
|
||||
|
||||
it('should return false if active execution is set and mode is not manual', () => {
|
||||
pinia.state.value.workflows.activeWorkflowExecution = { mode: 'webhook' };
|
||||
expect(useWorkflowsStore().shouldReplaceInputDataWithPinData).toBe(false);
|
||||
});
|
||||
});
|
||||
});
|
|
@ -248,6 +248,9 @@ export const useWorkflowsStore = defineStore(STORES.WORKFLOWS, {
|
|||
return acc;
|
||||
}, 0);
|
||||
},
|
||||
shouldReplaceInputDataWithPinData(): boolean {
|
||||
return !this.activeWorkflowExecution || this.activeWorkflowExecution?.mode === 'manual';
|
||||
},
|
||||
executedNode(): string | undefined {
|
||||
return this.workflowExecutionData ? this.workflowExecutionData.executedNode : undefined;
|
||||
},
|
||||
|
|
|
@ -3622,6 +3622,8 @@ export default defineComponent({
|
|||
type: 'error',
|
||||
});
|
||||
}
|
||||
} else if (json?.command === 'setActiveExecution') {
|
||||
this.workflowsStore.activeWorkflowExecution = json.execution;
|
||||
}
|
||||
} catch (e) {}
|
||||
},
|
||||
|
|
Loading…
Reference in a new issue