From b005686ecdb06fef15dc591efde4710a08025368 Mon Sep 17 00:00:00 2001 From: Zvonimir Erdelja Date: Tue, 30 Nov 2021 15:30:39 +0100 Subject: [PATCH 1/4] :bug: Fix typo in salesforce node description (#2500) --- .../nodes-base/nodes/Salesforce/OpportunityDescription.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/nodes-base/nodes/Salesforce/OpportunityDescription.ts b/packages/nodes-base/nodes/Salesforce/OpportunityDescription.ts index 95373a84b2..bab2f195ca 100644 --- a/packages/nodes-base/nodes/Salesforce/OpportunityDescription.ts +++ b/packages/nodes-base/nodes/Salesforce/OpportunityDescription.ts @@ -325,11 +325,11 @@ export const opportunityFields = [ options: [ { name: 'Business', - valie: 'Business', + value: 'Business', }, { name: 'New Business', - valie: 'New Business', + value: 'New Business', }, ], description: 'Type of opportunity. For example, Existing Business or New Business. Label is Opportunity Type.', From a550093f3e268727cf0d841f8cabe599f493324c Mon Sep 17 00:00:00 2001 From: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com> Date: Tue, 30 Nov 2021 20:37:55 +0100 Subject: [PATCH 2/4] :bug: Fix draggable memory leak (#2503) * attempt fix * wrap in try catch * Revert "wrap in try catch" 4b0444747f7c2f724c18f7bab6b769fba1727f07 * :zap: Improve comment Co-authored-by: Jan Oberhauser --- packages/editor-ui/src/views/NodeView.vue | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/packages/editor-ui/src/views/NodeView.vue b/packages/editor-ui/src/views/NodeView.vue index 239c3246cc..de33d7e3bc 100644 --- a/packages/editor-ui/src/views/NodeView.vue +++ b/packages/editor-ui/src/views/NodeView.vue @@ -2003,10 +2003,8 @@ export default mixins( this.$store.commit('renameNodeSelectedAndExecution', { old: currentName, new: newName }); // Reset all nodes and connections to load the new ones - if (this.instance) { - // On first load it does not exist - this.instance.deleteEveryEndpoint(); - } + this.deleteEveryEndpoint(); + this.$store.commit('removeAllConnections'); this.$store.commit('removeAllNodes', {setStateDirty: true}); @@ -2020,6 +2018,16 @@ export default mixins( this.deselectAllNodes(); this.nodeSelectedByName(newName); }, + deleteEveryEndpoint () { + // Check as it does not exist on first load + if (this.instance) { + const nodes = this.$store.getters.allNodes as INodeUi[]; + // @ts-ignore + nodes.forEach((node: INodeUi) => this.instance.destroyDraggable(`${NODE_NAME_PREFIX}${this.$store.getters.getNodeIndex(node.name)}`)); + + this.instance.deleteEveryEndpoint(); + } + }, matchCredentials(node: INodeUi) { if (!node.credentials) { return; @@ -2336,10 +2344,7 @@ export default mixins( }, resetWorkspace () { // Reset nodes - if (this.instance) { - // On first load it does not exist - this.instance.deleteEveryEndpoint(); - } + this.deleteEveryEndpoint(); if (this.executionWaitingForWebhook === true) { // Make sure that if there is a waiting test-webhook that From b07d5b8ea615ce1738952ec7ba96f184e92837fd Mon Sep 17 00:00:00 2001 From: m2scared <93332316+m2scared@users.noreply.github.com> Date: Tue, 30 Nov 2021 20:18:57 -0300 Subject: [PATCH 3/4] :zap: Fix RabbitMQTrigger default node name (#2505) The 'Trigger' sufix is missing. --- packages/nodes-base/nodes/RabbitMQ/RabbitMQTrigger.node.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/nodes-base/nodes/RabbitMQ/RabbitMQTrigger.node.ts b/packages/nodes-base/nodes/RabbitMQ/RabbitMQTrigger.node.ts index 3cb586dc59..ec6f28ecc1 100644 --- a/packages/nodes-base/nodes/RabbitMQ/RabbitMQTrigger.node.ts +++ b/packages/nodes-base/nodes/RabbitMQ/RabbitMQTrigger.node.ts @@ -25,7 +25,7 @@ export class RabbitMQTrigger implements INodeType { version: 1, description: 'Listens to RabbitMQ messages', defaults: { - name: 'RabbitMQ', + name: 'RabbitMQ Trigger', color: '#ff6600', }, inputs: [], From 0153beb8b1714bc6b007510140d30c0eb13cf1ea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Wed, 1 Dec 2021 00:19:54 +0100 Subject: [PATCH 4/4] :bug: Fix typos in Salesforce param descriptions (#2502) --- .../nodes-base/nodes/Salesforce/OpportunityDescription.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/nodes-base/nodes/Salesforce/OpportunityDescription.ts b/packages/nodes-base/nodes/Salesforce/OpportunityDescription.ts index bab2f195ca..f4d4f529ea 100644 --- a/packages/nodes-base/nodes/Salesforce/OpportunityDescription.ts +++ b/packages/nodes-base/nodes/Salesforce/OpportunityDescription.ts @@ -538,11 +538,11 @@ export const opportunityFields = [ options: [ { name: 'Business', - valie: 'Business', + value: 'Business', }, { name: 'New Business', - valie: 'New Business', + value: 'New Business', }, ], description: 'Type of opportunity. For example, Existing Business or New Business. Label is Opportunity Type.',