mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-11 12:57:29 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix(core): Enforce shutdown timer and sequence on SIGINT for main (#10346)
Some checks are pending
Test Master / install-and-build (push) Waiting to run
Details
Test Master / Unit tests (18.x) (push) Blocked by required conditions
Details
Test Master / Unit tests (20.x) (push) Blocked by required conditions
Details
Test Master / Unit tests (22.4) (push) Blocked by required conditions
Details
Test Master / Lint (push) Blocked by required conditions
Details
Test Master / Notify Slack on failure (push) Blocked by required conditions
Details

Browse source
This commit is contained in:
Iván Ovejero 2024-08-12 11:41:21 +02:00 committed by GitHub
parent b044e783e7
commit 5255793afe
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/cli/src/commands/BaseCommand.ts
View file

@ -315,7 +315,7 @@ export abstract class BaseCommand extends Command {
this.exit(exitCode); this.exit(exitCode);
} }
private onTerminationSignal(signal: string) { protected onTerminationSignal(signal: string) {
return async () => { return async () => {
if (this.shutdownService.isShuttingDown()) { if (this.shutdownService.isShuttingDown()) {
this.logger.info(`Received ${signal}. Already shutting down...`); this.logger.info(`Received ${signal}. Already shutting down...`);

2
packages/cli/src/commands/start.ts
View file

@ -332,7 +332,7 @@ export class Start extends BaseCommand {
this.openBrowser(); this.openBrowser();
} else if (key.charCodeAt(0) === 3) { } else if (key.charCodeAt(0) === 3) {
// Ctrl + c got pressed // Ctrl + c got pressed
void this.stopProcess(); void this.onTerminationSignal('SIGINT')();
} else { } else {
// When anything else got pressed, record it and send it on enter into the child process // When anything else got pressed, record it and send it on enter into the child process