mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-09-19 22:37:31 -07:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix(editor): Update tags filter/editor to not show non existing tag as a selectable option (#10297)

Browse source
This commit is contained in:
Csaba Tuncsik 2024-08-06 15:29:55 +02:00 committed by GitHub
parent 74554d21d7
commit 557a76ec23
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 21 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
cypress/e2e/17-workflow-tags.cy.ts
View file

@ -1,4 +1,5 @@
import { WorkflowPage } from '../pages';
import { getVisibleSelect } from '../utils';
const wf = new WorkflowPage();
@ -70,4 +71,20 @@ describe('Workflow tags', () => {
wf.getters.workflowTags().click();
wf.getters.tagPills().should('have.length', TEST_TAGS.length - 1);
});
it('should not show non existing tag as a selectable option', () => {
const NON_EXISTING_TAG = 'My Test Tag';
wf.getters.createTagButton().click();
wf.actions.addTags(TEST_TAGS);
cy.get('body').click(0, 0);
wf.getters.workflowTags().click();
wf.getters.tagsDropdown().find('input:focus').type(NON_EXISTING_TAG);
getVisibleSelect()
.find('li')
.should('have.length', 2)
.filter(`:contains("${NON_EXISTING_TAG}")`)
.should('not.have.length');
});
});

1
packages/editor-ui/src/components/MainHeader/WorkflowDetails.vue
View file

@ -639,7 +639,6 @@ function showCreateWorkflowSuccessToast(id?: string) {
v-if="isTagsEditEnabled && !readOnly"
ref="dropdown"
v-model="appliedTagIds"
:create-enabled="true"
:event-bus="tagsEventBus"
:placeholder="$locale.baseText('workflowDetails.chooseOrCreateATag')"
class="tags-edit"

13
packages/editor-ui/src/components/TagsDropdown.vue
View file

@ -13,7 +13,6 @@
:filter-method="filterOptions"
filterable
multiple
:allow-create="createEnabled"
:reserve-keyword="false"
loading-text="..."
popper-class="tags-dropdown"
@ -23,7 +22,7 @@
@remove-tag="onRemoveTag"
>
<n8n-option
v-if="options.length === 0 && filter && createEnabled"
v-if="options.length === 0 && filter"
:key="CREATE_KEY"
ref="createRef"
:value="CREATE_KEY"
@ -35,11 +34,11 @@
</span>
</n8n-option>
<n8n-option v-else-if="options.length === 0" value="message" disabled>
<span v-if="createEnabled">{{ i18n.baseText('tagsDropdown.typeToCreateATag') }}</span>
<span v-else-if="allTags.length > 0">{{
<span>{{ i18n.baseText('tagsDropdown.typeToCreateATag') }}</span>
<span v-if="allTags.length > 0">{{
i18n.baseText('tagsDropdown.noMatchingTagsExist')
}}</span>
<span v-else>{{ i18n.baseText('tagsDropdown.noTagsExist') }}</span>
<span v-else-if="filter">{{ i18n.baseText('tagsDropdown.noTagsExist') }}</span>
</n8n-option>
<!-- key is id+index for keyboard navigation to work well with filter -->
@ -90,10 +89,6 @@ export default defineComponent({
type: Array as PropType<string[]>,
default: () => [],
},
createEnabled: {
type: Boolean,
default: false,
},
eventBus: {
type: Object as PropType<EventBus>,
default: null,