mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: Enable Assistant on other credential views (#10931)

Browse source
This commit is contained in:
Mutasem Aldmour 2024-09-23 14:06:38 +02:00 committed by GitHub
parent eae4e30aee
commit 557db9c170
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 31 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
packages/editor-ui/src/stores/__tests__/assistant.store.test.ts
View file

@ -13,7 +13,7 @@ import { useSettingsStore } from '@/stores/settings.store';
import { defaultSettings } from '../../__tests__/defaults';
import { merge } from 'lodash-es';
import { DEFAULT_POSTHOG_SETTINGS } from './posthog.test';
import { AI_ASSISTANT_EXPERIMENT } from '@/constants';
import { AI_ASSISTANT_EXPERIMENT, VIEWS } from '@/constants';
import { reactive } from 'vue';
import * as chatAPI from '@/api/assistant';
import * as telemetryModule from '@/composables/useTelemetry';
@ -41,12 +41,13 @@ const setAssistantEnabled = (enabled: boolean) => {
);
};
let currentRouteName = ENABLED_VIEWS[0];
vi.mock('vue-router', () => ({
useRoute: vi.fn(() =>
reactive({
path: '/',
params: {},
name: ENABLED_VIEWS[0],
name: currentRouteName,
}),
),
useRouter: vi.fn(),
@ -309,6 +310,30 @@ describe('AI Assistant store', () => {
expect(assistantStore.canShowAssistantButtonsOnCanvas).toBe(true);
});
it('should not show assistant if on a settings page', () => {
currentRouteName = VIEWS.SSO_SETTINGS;
const assistantStore = useAssistantStore();
setAssistantEnabled(true);
mockPostHogVariant('variant');
expect(assistantStore.isAssistantEnabled).toBe(true);
expect(assistantStore.canShowAssistant).toBe(false);
expect(assistantStore.canShowAssistantButtonsOnCanvas).toBe(false);
});
[VIEWS.PROJECTS_CREDENTIALS, VIEWS.TEMPLATE_SETUP, VIEWS.CREDENTIALS].forEach((view) => {
it(`should show assistant if on ${view} page`, () => {
currentRouteName = VIEWS.PROJECTS_CREDENTIALS;
const assistantStore = useAssistantStore();
setAssistantEnabled(true);
mockPostHogVariant('variant');
expect(assistantStore.isAssistantEnabled).toBe(true);
expect(assistantStore.canShowAssistant).toBe(true);
expect(assistantStore.canShowAssistantButtonsOnCanvas).toBe(false);
});
});
it('should initialize assistant chat session on node error', async () => {
const context: ChatRequest.ErrorContext = {
error: {

4
packages/editor-ui/src/stores/assistant.store.ts
View file

@ -46,6 +46,10 @@ export const ENABLED_VIEWS = [
VIEWS.EXECUTION_PREVIEW,
VIEWS.WORKFLOWS,
VIEWS.CREDENTIALS,
VIEWS.PROJECTS_CREDENTIALS,
VIEWS.PROJECTS_WORKFLOWS,
VIEWS.PROJECT_SETTINGS,
VIEWS.TEMPLATE_SETUP,
];
const READABLE_TYPES = ['code-diff', 'text', 'block'];