mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 20:54:07 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: Prevent removing manual executions when setting says to save (#6300)

Browse source
This commit is contained in:
Omar Ajoue 2023-05-23 13:00:26 +02:00 committed by GitHub
parent d5c7e6f2cf
commit 55b755cb44
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/cli/src/WorkflowExecuteAdditionalData.ts
View file

@ -610,8 +610,7 @@ function hookFunctionsSave(parentProcessMode?: string): IWorkflowExecuteHooks {
(workflowDidSucceed && saveDataSuccessExecution === 'none') || (workflowDidSucceed && saveDataSuccessExecution === 'none') ||
(!workflowDidSucceed && saveDataErrorExecution === 'none') (!workflowDidSucceed && saveDataErrorExecution === 'none')
) { ) {
if (!fullRunData.waitTill) { if (!fullRunData.waitTill && !isManualMode) {
if (!isManualMode) {
executeErrorWorkflow( executeErrorWorkflow(
this.workflowData, this.workflowData,
fullRunData, fullRunData,
@ -619,7 +618,6 @@ function hookFunctionsSave(parentProcessMode?: string): IWorkflowExecuteHooks {
this.executionId, this.executionId,
this.retryOf, this.retryOf,
); );
}
// Data is always saved, so we remove from database // Data is always saved, so we remove from database
await Db.collections.Execution.delete(this.executionId); await Db.collections.Execution.delete(this.executionId);
await BinaryDataManager.getInstance().markDataForDeletionByExecutionId( await BinaryDataManager.getInstance().markDataForDeletionByExecutionId(