From 560b549bb5c39071855a5f9c8c7ab335cf24fd85 Mon Sep 17 00:00:00 2001 From: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com> Date: Tue, 12 Dec 2023 10:08:04 +0100 Subject: [PATCH] ci: Update PR template to simplify (no-changelog) (#7996) ## Summary > Describe what the PR does. And how to test. Photos and videos are recommended. Update PR template to simplify and reduce noise. ## Related tickets and issues > Include links to **Linear ticket** or Github issue or Community forum post. Important in order to close *automatically* and provide context to reviewers. N/A ## Review / Merge checklist - [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. > A feature is not complete without tests. --------- Co-authored-by: Tomi Turtiainen <10324676+tomi@users.noreply.github.com> --- .github/pull_request_template.md | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 804b35675f..dfcc0615a7 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,23 +1,16 @@ ## Summary -Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended. - -... - -#### How to test the change: -1. ... +> Describe what the PR does and how to test. Photos and videos are recommended. -## Issues fixed -Include links to Github issue or Community forum post or **Linear ticket**: -> Important in order to close automatically and provide context to reviewers -... +## Related tickets and issues +> Include links to **Linear ticket** or Github issue or Community forum post. Important in order to close *automatically* and provide context to reviewers. + ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. - > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. - > - > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e). \ No newline at end of file + > A bug is not considered fixed, unless a test is added to prevent it from happening again. + > A feature is not complete without tests. \ No newline at end of file