mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-02-02 07:01:30 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

handle another circular dependency scenario in DI

Browse source
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™ 2025-01-13 17:51:52 +01:00
parent 66be5cd907
commit 5776439ac8
No known key found for this signature in database
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
packages/@n8n/di/src/di.ts
View file

@ -96,9 +96,14 @@ class ContainerClass {
} else { } else {
const paramTypes = (Reflect.getMetadata('design:paramtypes', type) ?? const paramTypes = (Reflect.getMetadata('design:paramtypes', type) ??
[]) as Constructable[]; []) as Constructable[];
const dependencies = paramTypes.map(<P>(paramType: Constructable<P>) => const dependencies = paramTypes.map(<P>(paramType: Constructable<P>, index: number) => {
this.get(paramType), if (paramType === undefined) {
throw new DIError(
`Circular dependency detected in ${type.name} at index ${index}.\n${resolutionStack.map((t) => t.name).join(' -> ')}\n`,
); );
}
return this.get(paramType);
});
// Create new instance with resolved dependencies // Create new instance with resolved dependencies
instance = new (type as Constructable)(...dependencies) as T; instance = new (type as Constructable)(...dependencies) as T;
} }