mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(core): Fix trying to pipe a non stream on errors (no-changelog) (#5660)

Browse source
This commit is contained in:
agobrech 2023-03-09 17:48:33 +01:00 committed by GitHub
parent edf6313fa5
commit 5790e5e719
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
packages/core/src/NodeExecuteFunctions.ts
View file

@ -99,7 +99,7 @@ import type {
} from 'axios'; } from 'axios';
import axios from 'axios'; import axios from 'axios';
import url, { URL, URLSearchParams } from 'url'; import url, { URL, URLSearchParams } from 'url';
import type { Readable } from 'stream'; import { Readable } from 'stream';
import { access as fsAccess } from 'fs/promises'; import { access as fsAccess } from 'fs/promises';
import { createReadStream } from 'fs'; import { createReadStream } from 'fs';
@ -687,7 +687,12 @@ async function proxyRequestToAxios(
if (response) { if (response) {
Logger.debug('Request proxied to Axios failed', { status: response.status }); Logger.debug('Request proxied to Axios failed', { status: response.status });
let responseData = response.data; let responseData = response.data;
responseData = await binaryToBuffer(responseData);
if (Buffer.isBuffer(responseData) || responseData instanceof Readable) {
responseData = await binaryToBuffer(responseData).then((buffer) =>
buffer.toString('utf-8'),
);
}
error.message = `${response.status as number} - ${JSON.stringify(responseData)}`; error.message = `${response.status as number} - ${JSON.stringify(responseData)}`;
} }