mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-30 22:02:03 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(core): Ensure runners do not throw on unsupported console methods (#12167)

Browse source
This commit is contained in:
Iván Ovejero 2024-12-11 18:37:07 +01:00 committed by GitHub
parent 28f1f6b561
commit 57c6a6167d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 36 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
packages/@n8n/task-runner/src/js-task-runner/__tests__/js-task-runner.test.ts
View file

@ -136,6 +136,36 @@ describe('JsTaskRunner', () => {
]);
},
);
it('should not throw when using unsupported console methods', async () => {
const task = newTaskWithSettings({
code: `
console.warn('test');
console.error('test');
console.info('test');
console.debug('test');
console.trace('test');
console.dir({});
console.time('test');
console.timeEnd('test');
console.timeLog('test');
console.assert(true);
console.clear();
console.group('test');
console.groupEnd();
console.table([]);
return {json: {}}
`,
nodeMode: 'runOnceForAllItems',
});
await expect(
execTaskWithParams({
task,
taskData: newDataRequestResponse([wrapIntoJson({})]),
}),
).resolves.toBeDefined();
});
});
describe('built-in methods and variables available in the context', () => {

6
packages/@n8n/task-runner/src/js-task-runner/js-task-runner.ts
View file

@ -121,7 +121,13 @@ export class JsTaskRunner extends TaskRunner {
nodeTypes: this.nodeTypes,
});
const noOp = () => {};
const customConsole = {
// all except `log` are dummy methods that disregard without throwing, following existing Code node behavior
...Object.keys(console).reduce<Record<string, () => void>>((acc, name) => {
acc[name] = noOp;
return acc;
}, {}),
// Send log output back to the main process. It will take care of forwarding
// it to the UI or printing to console.
log: (...args: unknown[]) => {