From 58b3492b0dcf140920ec97ce6d50e91a6d3a01a6 Mon Sep 17 00:00:00 2001 From: Deborah Date: Mon, 4 Sep 2023 15:28:30 +0100 Subject: [PATCH] fix(editor): Standardize save text (#7093) Github issue / Community forum post (link here to close automatically): --------- Co-authored-by: Jonathan Bennetts --- .../src/components/WorkflowSettings.vue | 18 ++++++++++-------- .../editor-ui/src/plugins/i18n/locales/en.json | 8 ++++---- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/packages/editor-ui/src/components/WorkflowSettings.vue b/packages/editor-ui/src/components/WorkflowSettings.vue index c1114432f5..8461107ac3 100644 --- a/packages/editor-ui/src/components/WorkflowSettings.vue +++ b/packages/editor-ui/src/components/WorkflowSettings.vue @@ -687,19 +687,21 @@ export default defineComponent({ { interpolate: { defaultValue: this.defaultValues.saveExecutionProgress - ? this.$locale.baseText('workflowSettings.saveExecutionProgressOptions.yes') - : this.$locale.baseText('workflowSettings.saveExecutionProgressOptions.no'), + ? this.$locale.baseText('workflowSettings.saveExecutionProgressOptions.save') + : this.$locale.baseText( + 'workflowSettings.saveExecutionProgressOptions.doNotSave', + ), }, }, ), }, { key: true, - value: this.$locale.baseText('workflowSettings.saveExecutionProgressOptions.yes'), + value: this.$locale.baseText('workflowSettings.saveExecutionProgressOptions.save'), }, { key: false, - value: this.$locale.baseText('workflowSettings.saveExecutionProgressOptions.no'), + value: this.$locale.baseText('workflowSettings.saveExecutionProgressOptions.doNotSave'), }, ]); }, @@ -710,18 +712,18 @@ export default defineComponent({ value: this.$locale.baseText('workflowSettings.saveManualOptions.defaultSave', { interpolate: { defaultValue: this.defaultValues.saveManualExecutions - ? this.$locale.baseText('workflowSettings.saveManualOptions.yes') - : this.$locale.baseText('workflowSettings.saveManualOptions.no'), + ? this.$locale.baseText('workflowSettings.saveManualOptions.save') + : this.$locale.baseText('workflowSettings.saveManualOptions.doNotSave'), }, }), }); this.saveManualOptions.push({ key: true, - value: this.$locale.baseText('workflowSettings.saveManualOptions.yes'), + value: this.$locale.baseText('workflowSettings.saveManualOptions.save'), }); this.saveManualOptions.push({ key: false, - value: this.$locale.baseText('workflowSettings.saveManualOptions.no'), + value: this.$locale.baseText('workflowSettings.saveManualOptions.doNotSave'), }); }, diff --git a/packages/editor-ui/src/plugins/i18n/locales/en.json b/packages/editor-ui/src/plugins/i18n/locales/en.json index 487403fe96..d03cea2ab4 100644 --- a/packages/editor-ui/src/plugins/i18n/locales/en.json +++ b/packages/editor-ui/src/plugins/i18n/locales/en.json @@ -1733,12 +1733,12 @@ "workflowSettings.saveDataSuccessExecutionOptions.save": "@:_reusableBaseText.save", "workflowSettings.saveExecutionProgress": "Save execution progress", "workflowSettings.saveExecutionProgressOptions.defaultSave": "Default - {defaultValue}", - "workflowSettings.saveExecutionProgressOptions.no": "No", - "workflowSettings.saveExecutionProgressOptions.yes": "Yes", + "workflowSettings.saveExecutionProgressOptions.doNotSave": "Do not save", + "workflowSettings.saveExecutionProgressOptions.save": "@:_reusableBaseText.save", "workflowSettings.saveManualExecutions": "Save manual executions", "workflowSettings.saveManualOptions.defaultSave": "Default - {defaultValue}", - "workflowSettings.saveManualOptions.no": "No", - "workflowSettings.saveManualOptions.yes": "Yes", + "workflowSettings.saveManualOptions.doNotSave": "Do not save", + "workflowSettings.saveManualOptions.save": "@:_reusableBaseText.save", "workflowSettings.seconds": "seconds", "workflowSettings.selectOption": "Select Option", "workflowSettings.settingsFor": "Workflow settings for {workflowName} (#{workflowId})",