mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(editor): Show input selector when node has error (#12813)
Some checks are pending
Test Master / install-and-build (push) Waiting to run
Details
Test Master / Unit tests (18.x) (push) Blocked by required conditions
Details
Test Master / Unit tests (20.x) (push) Blocked by required conditions
Details
Test Master / Unit tests (22.4) (push) Blocked by required conditions
Details
Test Master / Lint (push) Blocked by required conditions
Details
Test Master / Notify Slack on failure (push) Blocked by required conditions
Details

Browse source
This commit is contained in:
Milorad FIlipović 2025-01-24 09:38:57 +01:00 committed by GitHub
parent f4bf55f0d8
commit 5b760e7f7f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 144 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

157
packages/editor-ui/src/components/RunData.test.ts
View file

@ -34,17 +34,6 @@ vi.mock('@/composables/useExecutionHelpers', () => ({
}),
}));
const nodes = [
{
id: '1',
typeVersion: 3,
name: 'Test Node',
position: [0, 0],
type: SET_NODE_TYPE,
parameters: {},
},
] as INodeUi[];
describe('RunData', () => {
beforeAll(() => {
resolveRelatedExecutionUrl.mockReturnValue('execution.url/123');
@ -398,8 +387,146 @@ describe('RunData', () => {
expect(trackOpeningRelatedExecution).toHaveBeenCalledWith(metadata, 'json');
});
it('should render input selector when input node has error', async () => {
const testNodes = [
{
id: '1',
name: 'When clicking ‘Test workflow’',
type: 'n8n-nodes-base.manualTrigger',
typeVersion: 1,
position: [80, -180],
disabled: false,
parameters: { notice: '' },
},
{
id: '2',
name: 'Edit Fields',
type: 'n8n-nodes-base.set',
parameters: {
mode: 'manual',
duplicateItem: false,
assignments: {
_custom: { type: 'reactive', stateTypeName: 'Reactive', value: {} },
},
includeOtherFields: false,
options: {},
},
typeVersion: 3.4,
position: [500, -180],
},
{
id: '3',
name: 'Test Node',
type: 'n8n-nodes-base.code',
parameters: {
mode: 'runOnceForAllItems',
language: 'javaScript',
jsCode: "throw Error('yo')",
notice: '',
},
typeVersion: 2,
position: [300, -180],
issues: {
_custom: {
type: 'reactive',
stateTypeName: 'Reactive',
value: { execution: true },
},
},
},
] as INodeUi[];
const { getByTestId } = render({
workflowNodes: testNodes,
runs: [
{
hints: [],
startTime: 1737643696893,
executionTime: 2,
source: [
{
previousNode: 'When clicking ‘Test workflow’',
},
],
executionStatus: 'error',
// @ts-expect-error allow missing properties in test
error: {
level: 'error',
tags: {
packageName: 'nodes-base',
},
description: null,
lineNumber: 1,
node: {
type: 'n8n-nodes-base.code',
typeVersion: 2,
position: [300, -180],
id: 'e41f12e0-d178-4294-8748-da5a6a531be6',
name: 'Test Node',
parameters: {
mode: 'runOnceForAllItems',
language: 'javaScript',
jsCode: "throw Error('yo')",
notice: '',
},
},
message: 'yo [line 1]',
stack: 'Error: yo\n n8n/packages/core/src/execution-engine/workflow-execute.ts:2066:11',
},
},
],
defaultRunItems: [
{
hints: [],
startTime: 1737641598215,
executionTime: 3,
// @ts-expect-error allow missing properties in test
source: [{ previousNode: 'Execute Workflow Trigger' }],
// @ts-expect-error allow missing properties in test
executionStatus: 'error',
// @ts-expect-error allow missing properties in test
error: {
level: 'error',
tags: { packageName: 'nodes-base' },
description: null,
lineNumber: 1,
node: {
id: 'e41f12e0-d178-4294-8748-da5a6a531be6',
name: 'Test Node',
type: 'n8n-nodes-base.code',
typeVersion: 2,
position: [300, -180],
parameters: {
mode: 'runOnceForAllItems',
language: 'javaScript',
jsCode: "throw Error('yo')",
notice: '',
},
},
message: 'yo [line 1]',
stack: 'Error: yo\n n8n/packages/core/src/execution-engine/workflow-execute.ts:2066:11',
},
},
],
});
expect(getByTestId('ndv-items-count')).toBeInTheDocument();
});
// Default values for the render function
const nodes = [
{
id: '1',
typeVersion: 3,
name: 'Test Node',
position: [0, 0],
type: SET_NODE_TYPE,
parameters: {},
},
] as INodeUi[];
const render = ({
defaultRunItems,
workflowNodes = nodes,
displayMode,
pinnedData,
paneType = 'output',
@ -407,6 +534,7 @@ describe('RunData', () => {
runs,
}: {
defaultRunItems?: INodeExecutionData[];
workflowNodes?: INodeUi[];
displayMode: IRunDataDisplayMode;
pinnedData?: INodeExecutionData[];
paneType?: NodePanelType;
@ -433,7 +561,7 @@ describe('RunData', () => {
},
[STORES.WORKFLOWS]: {
workflow: {
nodes,
workflowNodes,
},
workflowExecutionData: {
id: '1',
@ -468,7 +596,7 @@ describe('RunData', () => {
const nodeTypesStore = useNodeTypesStore();
nodeTypesStore.setNodeTypes(defaultNodeDescriptions);
vi.mocked(workflowsStore).getNodeByName.mockReturnValue(nodes[0]);
vi.mocked(workflowsStore).getNodeByName.mockReturnValue(workflowNodes[0]);
if (pinnedData) {
vi.mocked(workflowsStore).pinDataByNodeName.mockReturnValue(pinnedData);
@ -480,7 +608,8 @@ describe('RunData', () => {
name: 'Test Node',
},
workflow: createTestWorkflowObject({
nodes,
// @ts-expect-error allow missing properties in test
workflowNodes,
}),
},
global: {

3
packages/editor-ui/src/components/RunData.vue
View file

@ -1493,14 +1493,13 @@ defineExpose({ enterEditMode });
<div
v-else-if="
!hasRunError &&
hasNodeRun &&
!isSearchInSchemaView &&
((dataCount > 0 && maxRunIndex === 0) || search) &&
!isArtificialRecoveredEventItem &&
!displaysMultipleNodes
"
v-show="!editMode.enabled && !hasRunError"
v-show="!editMode.enabled"
:class="[$style.itemsCount, { [$style.muted]: paneType === 'input' && maxRunIndex === 0 }]"
data-test-id="ndv-items-count"
>