mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 12:44:07 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(HTTP Request Node): Do not create circular references in HTTP request node output (#8030)

Browse source 
## Summary
Remove unused `response.request` circular reference in http response
objects

## Related tickets
[PAY-1119](https://linear.app/n8n/issue/PAY-1119)

## Review / Merge checklist
- [x] PR title and summary are descriptive.
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™ 2023-12-15 16:40:39 +01:00 committed by GitHub
parent 67bd8ad698
commit 5b7ea16d9a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/nodes-base/nodes/HttpRequest/V1/HttpRequestV1.node.ts
View file

@ -993,6 +993,7 @@ export class HttpRequestV1 implements INodeType {
} }
response = response.value; response = response.value;
delete response.request;
const options = this.getNodeParameter('options', itemIndex, {}); const options = this.getNodeParameter('options', itemIndex, {});

1
packages/nodes-base/nodes/HttpRequest/V2/HttpRequestV2.node.ts
View file

@ -1046,6 +1046,7 @@ export class HttpRequestV2 implements INodeType {
} }
response = response.value; response = response.value;
delete response.request;
const options = this.getNodeParameter('options', itemIndex, {}); const options = this.getNodeParameter('options', itemIndex, {});

1
packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts
View file

@ -1767,6 +1767,7 @@ export class HttpRequestV3 implements INodeType {
// eslint-disable-next-line prefer-const // eslint-disable-next-line prefer-const
for (let [index, response] of Object.entries(responses)) { for (let [index, response] of Object.entries(responses)) {
delete response.request;
if (this.getMode() === 'manual' && index === '0') { if (this.getMode() === 'manual' && index === '0') {
// For manual executions save the first response in the context // For manual executions save the first response in the context
// so that we can use it in the frontend and so make it easier for // so that we can use it in the frontend and so make it easier for