mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-24 20:24:05 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix: Add missing Node.js natives to task runners (no-changelog) (#11362)

Browse source
This commit is contained in:
Val 2024-10-23 10:41:10 +01:00 committed by GitHub
parent 0708b3a1f8
commit 5b98f8711f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 38 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
packages/@n8n/task-runner/src/js-task-runner/__tests__/js-task-runner.test.ts
View file

@ -283,7 +283,7 @@ describe('JsTaskRunner', () => {
});
it('should allow access to Node.js Buffers', async () => {
const outcome = await execTaskWithParams({
const outcomeAll = await execTaskWithParams({
task: newTaskWithSettings({
code: 'return { val: Buffer.from("test-buffer").toString() }',
nodeMode: 'runOnceForAllItems',
@ -293,7 +293,21 @@ describe('JsTaskRunner', () => {
}),
});
expect(outcome.result).toEqual([wrapIntoJson({ val: 'test-buffer' })]);
expect(outcomeAll.result).toEqual([wrapIntoJson({ val: 'test-buffer' })]);
const outcomePer = await execTaskWithParams({
task: newTaskWithSettings({
code: 'return { val: Buffer.from("test-buffer").toString() }',
nodeMode: 'runOnceForEachItem',
}),
taskData: newAllCodeTaskData(inputItems.map(wrapIntoJson), {
envProviderState: undefined,
}),
});
expect(outcomePer.result).toEqual([
{ ...wrapIntoJson({ val: 'test-buffer' }), pairedItem: { item: 0 } },
]);
});
});

34
packages/@n8n/task-runner/src/js-task-runner/js-task-runner.ts
View file

@ -153,6 +153,25 @@ export class JsTaskRunner extends TaskRunner {
};
}
private getNativeVariables() {
return {
// Exposed Node.js globals in vm2
Buffer,
Function,
eval,
setTimeout,
setInterval,
setImmediate,
clearTimeout,
clearInterval,
clearImmediate,
// Missing JS natives
btoa,
atob,
};
}
/**
* Executes the requested code for all items in a single run
*/
@ -170,19 +189,9 @@ export class JsTaskRunner extends TaskRunner {
require: this.requireResolver,
module: {},
console: customConsole,
// Exposed Node.js globals in vm2
Buffer,
Function,
eval,
setTimeout,
setInterval,
setImmediate,
clearTimeout,
clearInterval,
clearImmediate,
items: inputItems,
...this.getNativeVariables(),
...dataProxy,
...this.buildRpcCallObject(taskId),
};
@ -232,6 +241,7 @@ export class JsTaskRunner extends TaskRunner {
console: customConsole,
item,
...this.getNativeVariables(),
...dataProxy,
...this.buildRpcCallObject(taskId),
};