fix(editor): Only fetch new versions at app launch (#5647)

only call nextVersions once
This commit is contained in:
romainminaud 2023-03-09 11:01:30 +01:00 committed by GitHub
parent 6500e985ee
commit 5b9c521d04
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 7 deletions

View file

@ -46,8 +46,9 @@ import { useRootStore } from './stores/n8nRootStore';
import { useTemplatesStore } from './stores/templates'; import { useTemplatesStore } from './stores/templates';
import { useNodeTypesStore } from './stores/nodeTypes'; import { useNodeTypesStore } from './stores/nodeTypes';
import { historyHelper } from '@/mixins/history'; import { historyHelper } from '@/mixins/history';
import { newVersions } from '@/mixins/newVersions';
export default mixins(showMessage, userHelpers, restApi, historyHelper).extend({ export default mixins(newVersions, showMessage, userHelpers, restApi, historyHelper).extend({
name: 'App', name: 'App',
components: { components: {
LoadingView, LoadingView,
@ -186,6 +187,7 @@ export default mixins(showMessage, userHelpers, restApi, historyHelper).extend({
this.logHiringBanner(); this.logHiringBanner();
this.authenticate(); this.authenticate();
this.redirectIfNecessary(); this.redirectIfNecessary();
this.checkForNewVersions();
this.loading = false; this.loading = false;

View file

@ -208,7 +208,6 @@ import { restApi } from '@/mixins/restApi';
import useGlobalLinkActions from '@/composables/useGlobalLinkActions'; import useGlobalLinkActions from '@/composables/useGlobalLinkActions';
import { showMessage } from '@/mixins/showMessage'; import { showMessage } from '@/mixins/showMessage';
import { titleChange } from '@/mixins/titleChange'; import { titleChange } from '@/mixins/titleChange';
import { newVersions } from '@/mixins/newVersions';
import { workflowHelpers } from '@/mixins/workflowHelpers'; import { workflowHelpers } from '@/mixins/workflowHelpers';
import { workflowRun } from '@/mixins/workflowRun'; import { workflowRun } from '@/mixins/workflowRun';
@ -327,7 +326,6 @@ export default mixins(
titleChange, titleChange,
workflowHelpers, workflowHelpers,
workflowRun, workflowRun,
newVersions,
debounceHelper, debounceHelper,
).extend({ ).extend({
name: 'NodeView', name: 'NodeView',
@ -3885,7 +3883,6 @@ export default mixins(
setTimeout(() => { setTimeout(() => {
this.usersStore.showPersonalizationSurvey(); this.usersStore.showPersonalizationSurvey();
this.checkForNewVersions();
this.addPinDataConnections(this.workflowsStore.getPinData || ({} as IPinData)); this.addPinDataConnections(this.workflowsStore.getPinData || ({} as IPinData));
}, 0); }, 0);
}); });

View file

@ -119,7 +119,6 @@
<script lang="ts"> <script lang="ts">
import { showMessage } from '@/mixins/showMessage'; import { showMessage } from '@/mixins/showMessage';
import { newVersions } from '@/mixins/newVersions';
import mixins from 'vue-typed-mixins'; import mixins from 'vue-typed-mixins';
import SettingsView from './SettingsView.vue'; import SettingsView from './SettingsView.vue';
@ -148,7 +147,7 @@ const StatusFilter = {
ALL: '', ALL: '',
}; };
const WorkflowsView = mixins(showMessage, debounceHelper, newVersions).extend({ const WorkflowsView = mixins(showMessage, debounceHelper).extend({
name: 'WorkflowsView', name: 'WorkflowsView',
components: { components: {
ResourcesListLayout, ResourcesListLayout,
@ -277,7 +276,6 @@ const WorkflowsView = mixins(showMessage, debounceHelper, newVersions).extend({
}, },
}, },
mounted() { mounted() {
this.checkForNewVersions();
this.usersStore.showPersonalizationSurvey(); this.usersStore.showPersonalizationSurvey();
}, },
}); });